Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(714)

Unified Diff: content/renderer/render_widget.h

Issue 2278283002: Implement Mac Pop-up Dictionary for OOPIF. (Closed)
Patch Set: Addressing lfg@'s comment Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/render_view_impl.cc ('k') | content/renderer/render_widget.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/render_widget.h
diff --git a/content/renderer/render_widget.h b/content/renderer/render_widget.h
index dc1d2c08a80627e6dd32e1b457b95b55c1066962..f55ceca7af1e9455d59a1b5c2fd62da45b0856f6 100644
--- a/content/renderer/render_widget.h
+++ b/content/renderer/render_widget.h
@@ -98,6 +98,7 @@ class RenderWidgetCompositor;
class RenderWidgetOwnerDelegate;
class RenderWidgetScreenMetricsEmulator;
class ResizingModeSelector;
+class TextInputClientObserver;
struct ContextMenuParams;
struct ResizeParams;
@@ -399,6 +400,9 @@ class CONTENT_EXPORT RenderWidget
return mouse_lock_dispatcher_.get();
}
+ // TODO(ekaramad): The reference to the focused pepper plugin will be removed
+ // from RenderWidget. The purpose of having the reference here was to make IME
+ // work for OOPIF (https://crbug.com/643727).
void set_focused_pepper_plugin(PepperPluginInstanceImpl* plugin) {
focused_pepper_plugin_ = plugin;
}
@@ -815,6 +819,12 @@ class CONTENT_EXPORT RenderWidget
// Indicates whether this widget has focus.
bool has_focus_;
+#if defined(OS_MACOSX)
+ // Responds to IPCs from TextInputClientMac regarding getting string at given
+ // position or range as well as finding character index at a given position.
+ std::unique_ptr<TextInputClientObserver> text_input_client_observer_;
+#endif
+
// This reference is set by the RenderFrame and is used to query the IME-
// related state from the plugin to later send to the browser.
PepperPluginInstanceImpl* focused_pepper_plugin_;
« no previous file with comments | « content/renderer/render_view_impl.cc ('k') | content/renderer/render_widget.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698