Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(828)

Unified Diff: third_party/WebKit/Source/web/tests/WebViewTest.cpp

Issue 2278283002: Implement Mac Pop-up Dictionary for OOPIF. (Closed)
Patch Set: Rebased Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/tests/WebViewTest.cpp
diff --git a/third_party/WebKit/Source/web/tests/WebViewTest.cpp b/third_party/WebKit/Source/web/tests/WebViewTest.cpp
index 74c4835ccd8cdfca91e15546f9ecdffa5f22b605..c8191d77997a2673aa7c85e8a7db4dd61fd6c20d 100644
--- a/third_party/WebKit/Source/web/tests/WebViewTest.cpp
+++ b/third_party/WebKit/Source/web/tests/WebViewTest.cpp
@@ -3237,7 +3237,7 @@ TEST_F(WebViewTest, WebSubstringUtil)
ASSERT_TRUE(!!result);
WebPoint point(baselinePoint.x, frameView->height() - baselinePoint.y);
- result = WebSubstringUtil::attributedWordAtPoint(webView, point, baselinePoint);
+ result = WebSubstringUtil::attributedWordAtPoint(webView, nullptr, point, baselinePoint);
ASSERT_TRUE(!!result);
webView->setZoomLevel(3);
@@ -3246,7 +3246,7 @@ TEST_F(WebViewTest, WebSubstringUtil)
ASSERT_TRUE(!!result);
point = WebPoint(baselinePoint.x, frameView->height() - baselinePoint.y);
- result = WebSubstringUtil::attributedWordAtPoint(webView, point, baselinePoint);
+ result = WebSubstringUtil::attributedWordAtPoint(webView, nullptr, point, baselinePoint);
ASSERT_TRUE(!!result);
}
@@ -3266,7 +3266,7 @@ TEST_F(WebViewTest, WebSubstringUtilIframe)
ASSERT_NE(result, nullptr);
WebPoint point(baselinePoint.x, mainFrame->frameView()->height() - baselinePoint.y);
- result = WebSubstringUtil::attributedWordAtPoint(webView, point, baselinePoint);
+ result = WebSubstringUtil::attributedWordAtPoint(webView, nullptr, point, baselinePoint);
ASSERT_NE(result, nullptr);
int yBeforeChange = baselinePoint.y;
@@ -3276,7 +3276,7 @@ TEST_F(WebViewTest, WebSubstringUtilIframe)
"document.querySelector('iframe').style.marginTop = '100px';"));
point = WebPoint(point.x, point.y + 100);
- result = WebSubstringUtil::attributedWordAtPoint(webView, point, baselinePoint);
+ result = WebSubstringUtil::attributedWordAtPoint(webView, nullptr, point, baselinePoint);
ASSERT_NE(result, nullptr);
EXPECT_EQ(yBeforeChange, baselinePoint.y + 100);

Powered by Google App Engine
This is Rietveld 408576698