content/browser/renderer_host/render_widget_host_input_event_router.h - Issue 2278283002: Implement Mac Pop-up Dictionary for OOPIF.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_widget_host_input_event_router.h

Issue 2278283002: Implement Mac Pop-up Dictionary for OOPIF. (Closed)

Patch Set: Added Tests and Modified DEPS Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | content/browser/renderer_host/render_widget_host_input_event_router.cc » ('j') | content/browser/renderer_host/render_widget_host_view_mac.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/render_widget_host_input_event_router.h

diff --git a/content/browser/renderer_host/render_widget_host_input_event_router.h b/content/browser/renderer_host/render_widget_host_input_event_router.h

index 83736c4973dbd2b435f5d09a9041ae9db12e900e..219b1699607af67e653568db3ee7a85006a3580f 100644

--- a/content/browser/renderer_host/render_widget_host_input_event_router.h

+++ b/content/browser/renderer_host/render_widget_host_input_event_router.h

@@ -38,6 +38,7 @@ class LatencyInfo;

namespace content {

+class RenderWidgetHost;

class RenderWidgetHostViewBase;

// Class owned by WebContentsImpl for the purpose of directing input events

@@ -79,6 +80,13 @@ class CONTENT_EXPORT RenderWidgetHostInputEventRouter

void OnHittestData(const FrameHostMsg_HittestData_Params& params);

+#if defined(OS_MACOSX)

+ RenderWidgetHost* GetRenderWidgetHostAtPos(

Charlie Reis 2016/08/31 22:50:03 nit: Needs comment (e.g., explaining |point| vs |t

EhsanK 2016/09/01 21:58:36 Done.

+ RenderWidgetHostViewBase* root_view,

+ const gfx::Point& point,

+ gfx::Point* transformed_point);

+#endif

private:

struct HittestData {

bool ignored_for_hittest;