third_party/WebKit/Source/web/WebViewFrameWidget.h - Issue 2278283002: Implement Mac Pop-up Dictionary for OOPIF.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/web/WebViewFrameWidget.h

Issue 2278283002: Implement Mac Pop-up Dictionary for OOPIF. (Closed)

Patch Set: Addressing lfg@'s comment Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp ('k') | third_party/WebKit/Source/web/WebViewFrameWidget.cpp » ('j') | no next file with comments »

OLD	NEW
1 // Copyright 2015 The Chromium Authors. All rights reserved.	1 // Copyright 2015 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be found	2 // Use of this source code is governed by a BSD-style license that can be found

3 // in the LICENSE file.	3 // in the LICENSE file.

4	4

5 #ifndef WebViewFrameWidget_h	5 #ifndef WebViewFrameWidget_h

6 #define WebViewFrameWidget_h	6 #define WebViewFrameWidget_h

7	7

8 #include "platform/heap/Handle.h"	8 #include "platform/heap/Handle.h"

9 #include "web/WebFrameWidgetBase.h"	9 #include "web/WebFrameWidgetBase.h"

10 #include "web/WebLocalFrameImpl.h"	10 #include "web/WebLocalFrameImpl.h"

(...skipping 86 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
97	97

98 // WebFrameWidgetBase overrides:	98 // WebFrameWidgetBase overrides:

99 bool forSubframe() const override { return false; }	99 bool forSubframe() const override { return false; }

100 void scheduleAnimation() override;	100 void scheduleAnimation() override;

101 CompositorProxyClient* createCompositorProxyClient() override;	101 CompositorProxyClient* createCompositorProxyClient() override;

102 void setRootGraphicsLayer(GraphicsLayer*) override;	102 void setRootGraphicsLayer(GraphicsLayer*) override;

103 void setRootLayer(WebLayer*) override;	103 void setRootLayer(WebLayer*) override;

104 void attachCompositorAnimationTimeline(CompositorAnimationTimeline*) overrid e;	104 void attachCompositorAnimationTimeline(CompositorAnimationTimeline*) overrid e;

105 void detachCompositorAnimationTimeline(CompositorAnimationTimeline*) overrid e;	105 void detachCompositorAnimationTimeline(CompositorAnimationTimeline*) overrid e;

106 WebWidgetClient* client() const override { return m_client; }	106 WebWidgetClient* client() const override { return m_client; }

	107 HitTestResult coreHitTestResultAt(const WebPoint&) override;

107	108

108 private:	109 private:

109 WebWidgetClient* m_client;	110 WebWidgetClient* m_client;

110 RefPtr<WebViewImpl> m_webView;	111 RefPtr<WebViewImpl> m_webView;

111 Persistent<WebLocalFrameImpl> m_mainFrame;	112 Persistent<WebLocalFrameImpl> m_mainFrame;

112 };	113 };

113	114

114 } // namespace blink	115 } // namespace blink

115	116

116 #endif // WebViewFrameWidget_h	117 #endif // WebViewFrameWidget_h

OLD	NEW