Implement Mac Pop-up Dictionary for OOPIF.

content/browser/renderer_host/text_input_client_mac.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "content/browser/renderer_host/text_input_client_mac.h"
 
 #include "base/memory/singleton.h"
 #include "base/metrics/histogram_macros.h"
 #include "base/threading/thread_restrictions.h"
 #include "base/time/time.h"
@@ skipping 19 matching lines @@
 
 // static
 TextInputClientMac* TextInputClientMac::GetInstance() {
   return base::Singleton<TextInputClientMac>::get();
 }
 
 void TextInputClientMac::GetStringAtPoint(
     RenderWidgetHost* rwh,
     gfx::Point point,
     void (^reply_handler)(NSAttributedString*, NSPoint)) {
+  // TODO(ekaramad): In principle, we are using the same handler regardless of
+  // the |rwh| which requested this. We should track the callbacks for each
+  // |rwh| individually so that one slow RWH will not end up clearing the
+  // callback for another (https://crbug.com/643233).
   DCHECK(replyForPointHandler_.get() == nil);
   replyForPointHandler_.reset(reply_handler, base::scoped_policy::RETAIN);
   RenderWidgetHostImpl* rwhi = RenderWidgetHostImpl::From(rwh);
   rwhi->Send(new TextInputClientMsg_StringAtPoint(rwhi->GetRoutingID(), point));
 }
 
 void TextInputClientMac::GetStringAtPointReply(NSAttributedString* string,
                                                NSPoint point) {
   if (replyForPointHandler_.get()) {
     replyForPointHandler_.get()(string, point);
@@ skipping 86 matching lines @@
 
   character_index_ = NSNotFound;
   first_rect_ = NSZeroRect;
 }
 
 void TextInputClientMac::AfterRequest() {
   lock_.Release();
 }
 
 }  // namespace content