Implement Mac Pop-up Dictionary for OOPIF.

content/renderer/render_frame_impl.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_RENDERER_RENDER_FRAME_IMPL_H_
 #define CONTENT_RENDERER_RENDER_FRAME_IMPL_H_
 
 #include <stddef.h>
 #include <stdint.h>
 
@@ skipping 131 matching lines @@
 class RendererMediaPlayerManager;
 class RendererMediaSessionManager;
 class RendererPpapiHost;
 class RendererSurfaceViewManager;
 class RenderFrameObserver;
 class RenderViewImpl;
 class RenderWidget;
 class RenderWidgetFullscreenPepper;
 class ResourceRequestBodyImpl;
 class ScreenOrientationDispatcher;
+class TextInputClientObserver;
 class UserMediaClientImpl;
 class WakeLockDispatcher;
 struct CommonNavigationParams;
 struct CustomContextMenuContext;
 struct FileChooserFileInfo;
 struct FileChooserParams;
 struct FrameOwnerProperties;
 struct FrameReplicationState;
 struct NavigationParams;
 struct RequestNavigationParams;
@@ skipping 522 matching lines @@
   void PepperInstanceDeleted(PepperPluginInstanceImpl* instance);
 
   // Notification that the given plugin is focused or unfocused.
   void PepperFocusChanged(PepperPluginInstanceImpl* instance, bool focused);
 
   void PepperStartsPlayback(PepperPluginInstanceImpl* instance);
   void PepperStopsPlayback(PepperPluginInstanceImpl* instance);
   void OnSetPepperVolume(int32_t pp_instance, double volume);
 #endif  // ENABLE_PLUGINS
 
+#if defined(OS_MACOSX)
+  void OnTextInputClientMessageReceived(RenderWidget* render_widget,
+                                        const IPC::Message& message);
+#endif
+
  protected:
   explicit RenderFrameImpl(const CreateParams& params);
 
  private:
   friend class RenderFrameImplTest;
   friend class RenderFrameObserver;
   friend class RenderAccessibilityImplTest;
   friend class TestRenderFrame;
   FRIEND_TEST_ALL_PREFIXES(ExternalPopupMenuDisplayNoneTest, SelectItem);
   FRIEND_TEST_ALL_PREFIXES(ExternalPopupMenuRemoveTest, RemoveOnChange);
@@ skipping 559 matching lines @@
   // Whether or not the focus is on a PPAPI plugin
   PepperPluginInstanceImpl* focused_pepper_plugin_;
 
   // The plugin instance that received the last mouse event. It is set to NULL
   // if the last mouse event went to elements other than Pepper plugins.
   // |pepper_last_mouse_event_target_| is not owned by this class. We depend on
   // the RenderFrameImpl to NULL it out when it destructs.
   PepperPluginInstanceImpl* pepper_last_mouse_event_target_;
 #endif
 
+#if defined(OS_MACOSX)
+  // The receiver end for TextInputClientMac messages at this local root.
+  std::unique_ptr<TextInputClientObserver> text_input_client_observer_;

[Charlie Reis, 2016/09/02 21:57:47]

Maybe add a TODO to move this to RenderWidget if that's the intention?

[EhsanK, 2016/09/08 17:10:40]

Done. I added a TODO. That being said, with lfg@'s ongoing patch on returning a
WebFrameWidgetBase 
for RenderWidget::GetWebWidget() I think I will be able to get rid of this for
good in this patch. My main blocker for that has been access to
RenderView->webview() to case it to WebViewImpl dow the road. Now I can expose a
method in WebViewFrameWidget and move the ownership of TextInputClienObserver to
RenderWidget within this patch.

[Charlie Reis, 2016/09/09 22:23:32]

Acknowledged.

+#endif
+
   mojo::Binding<mojom::Frame> frame_binding_;
   mojom::FrameHostPtr frame_host_;
 
   // Indicates whether |didAccessInitialDocument| was called.
   bool has_accessed_initial_document_;
 
   base::WeakPtrFactory<RenderFrameImpl> weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(RenderFrameImpl);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_RENDERER_RENDER_FRAME_IMPL_H_