Implement Mac Pop-up Dictionary for OOPIF.

content/browser/renderer_host/render_widget_host_input_event_router.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_INPUT_EVENT_ROUTER_H_
 #define CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_INPUT_EVENT_ROUTER_H_
 
 #include <stdint.h>
 
 #include <deque>
@@ skipping 20 matching lines @@
 namespace gfx {
 class Point;
 }
 
 namespace ui {
 class LatencyInfo;
 }
 
 namespace content {
 
+class RenderWidgetHostImpl;

[Charlie Reis, 2016/09/02 21:57:47]

Stale?

[kenrb, 2016/09/06 18:14:48]

This declares the Impl, so I don't think it's stale. (?)

[Charlie Reis, 2016/09/06 21:58:26]

Ah yes, ignore this one.  (I must have been overeager when retyping my
comments.)  :)

 class RenderWidgetHostViewBase;
 
 // Class owned by WebContentsImpl for the purpose of directing input events
 // to the correct RenderWidgetHost on pages with multiple RenderWidgetHosts.
 // It maintains a mapping of RenderWidgetHostViews to Surface IDs that they
 // own. When an input event requires routing based on window coordinates,
 // this class requests a Surface hit test from the provided |root_view| and
 // forwards the event to the owning RWHV of the returned Surface ID.
 class CONTENT_EXPORT RenderWidgetHostInputEventRouter
     : public RenderWidgetHostViewBaseObserver {
@@ skipping 21 matching lines @@
 
   void AddSurfaceClientIdOwner(uint32_t id, RenderWidgetHostViewBase* owner);
   void RemoveSurfaceClientIdOwner(uint32_t id);
 
   bool is_registered(uint32_t id) {
     return owner_map_.find(id) != owner_map_.end();
   }
 
   void OnHittestData(const FrameHostMsg_HittestData_Params& params);
 
+#if defined(OS_MACOSX)

[kenrb, 2016/09/06 18:14:48]

Is the #ifdef necessary here? I don't see anything wrong with exposing this as a
method for all platforms, even if it is only currently used on one.

[EhsanK, 2016/09/08 17:10:39]

Acknowledged.

+  // Returns the RenderWidgetHostImpl inside the |root_view| at |point| where
+  // |point| is with respect to |root_view|'s coordinates. If a RWHI is found,
+  // the value of |transformed_point| is the coordinate of the point with
+  // respect to the RWHI's coordinates.
+  RenderWidgetHostImpl* GetRenderWidgetHostAtPoint(
+      RenderWidgetHostViewBase* root_view,
+      const gfx::Point& point,
+      gfx::Point* transformed_point);
+#endif
+
  private:
   struct HittestData {
     bool ignored_for_hittest;
   };
 
   class HittestDelegate : public cc::SurfaceHittestDelegate {
    public:
     HittestDelegate(
         const std::unordered_map<cc::SurfaceId, HittestData, cc::SurfaceIdHash>&
             hittest_data);
@@ skipping 56 matching lines @@
   DISALLOW_COPY_AND_ASSIGN(RenderWidgetHostInputEventRouter);
   FRIEND_TEST_ALL_PREFIXES(SitePerProcessBrowserTest,
                            InputEventRouterGestureTargetQueueTest);
   FRIEND_TEST_ALL_PREFIXES(SitePerProcessBrowserTest,
                            InputEventRouterTouchpadGestureTargetTest);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_INPUT_EVENT_ROUTER_H_