Implement Mac Pop-up Dictionary for OOPIF.

content/renderer/render_widget.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_RENDERER_RENDER_WIDGET_H_
 #define CONTENT_RENDERER_RENDER_WIDGET_H_
 
 #include <stddef.h>
 #include <stdint.h>
 
@@ skipping 362 matching lines @@
   bool has_focus() const { return has_focus_; }
 
   MouseLockDispatcher* mouse_lock_dispatcher() {
     return mouse_lock_dispatcher_.get();
   }
 
   void set_focused_pepper_plugin(PepperPluginInstanceImpl* plugin) {
     focused_pepper_plugin_ = plugin;
   }
 
+  PepperPluginInstanceImpl* focused_pepper_plugin() const {

[Charlie Reis, 2016/08/31 22:50:03]

lfg@: Can you review this part?  I know you had some thoughts on this recently.

[lfg, 2016/09/01 15:42:27]

I really don't like this. We shouldn't be exposing focused_pepper_plugin()
through RenderWidget. I was ok with adding this to RenderWidget because we had
to fix the blocking issue with IME, but I think we should now try to find a
better solution.

Here's what I propose: 1) Add a RenderWidgetDelegate abstraction that has the
needed IME-related functions. 2) Add an IME class the implements
RenderWidgetDelegate. This IME class can keep track of all the frames in the
local root, and we should rely on the RenderFrame as the only source for the
focused_pepper_plugin (we already saw that having this in RenderWidget is
fragile with a use-after-free last week).

[EhsanK, 2016/09/01 21:58:37]

For now I have removed this line of code and pass RenderFrameImpl (local root)
to TextInputClientObserver).

I think having a middle interface like the RenderWidgetDelegate is very useful.
I am not sure if RenderFrameImpl is a good candidate for implementing the
interface, or we should have a separate implementation owned by (maybe)
RenderFrame.

[lfg, 2016/09/02 16:39:00]

Can you file a bug and add a TODO to fix the focused_pepper_plugin issue in
RenderWidget?

+    return focused_pepper_plugin_;
+  }
+
   // When emulated, this returns original device scale factor.
   float GetOriginalDeviceScaleFactor() const;
 
  protected:
   // Friend RefCounted so that the dtor can be non-public. Using this class
   // without ref-counting is an error.
   friend class base::RefCounted<RenderWidget>;
 
   // For unit tests.
   friend class RenderWidgetTest;
@@ skipping 401 matching lines @@
   // This reference is set by the RenderFrame and is used to query the IME-
   // related state from the plugin to later send to the browser.
   PepperPluginInstanceImpl* focused_pepper_plugin_;
 
   DISALLOW_COPY_AND_ASSIGN(RenderWidget);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_RENDERER_RENDER_WIDGET_H_