Fix CSS reference filters with negative transformed children.

cc/layers/layer.cc

 // Copyright 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "cc/layers/layer.h"
 
 #include <stddef.h>
 #include <stdint.h>
 
 #include <algorithm>
@@ skipping 459 matching lines @@
 
 void Layer::SetBackgroundFilters(const FilterOperations& filters) {
   DCHECK(IsPropertyChangeAllowed());
   if (inputs_.background_filters == filters)
     return;
   inputs_.background_filters = filters;
   SetLayerPropertyChanged();
   SetNeedsCommit();
 }
 
+void Layer::SetFiltersOrigin(const gfx::PointF& filters_origin) {
+  DCHECK(IsPropertyChangeAllowed());
+  if (inputs_.filters_origin == filters_origin)
+    return;
+  inputs_.filters_origin = filters_origin;
+  SetSubtreePropertyChanged();  // TODO(senorblanco) or SetLayerPropertyChanged?

[Stephen White, 2016/08/29 21:10:54]

Ali: any comment on this TODO? I notice that SetFilters() uses
SetSubtreePropertyChanged(), but SetBackgroundFilters() uses
SetLayerPropertyChanged(). Any idea which one I should be using?

[ajuma, 2016/08/29 21:39:30]

It should be SetSubtreePropertyChanged (since the dirty region on screen depends
on the bounds of all descendants). I think the difference for background filters
is that the dirty region depends only on the bounds of the layer itself (and on
the filter).

[Stephen White, 2016/08/29 21:43:11]

Thanks! TODO removed.

+  SetNeedsCommit();
+}
+
 void Layer::SetOpacity(float opacity) {
   DCHECK(IsPropertyChangeAllowed());
   DCHECK_GE(opacity, 0.f);
   DCHECK_LE(opacity, 1.f);
 
   if (inputs_.opacity == opacity)
     return;
   // We need to force a property tree rebuild when opacity changes from 1 to a
   // non-1 value or vice-versa as render surfaces can change.
   bool force_rebuild = opacity == 1.f || inputs_.opacity == 1.f;
@@ skipping 629 matching lines @@
 void Layer::PushPropertiesTo(LayerImpl* layer) {
   TRACE_EVENT0("cc", "Layer::PushPropertiesTo");
   DCHECK(layer_tree_host_);
 
   // If we did not SavePaintProperties() for the layer this frame, then push the
   // real property values, not the paint property values.
   bool use_paint_properties = paint_properties_.source_frame_number ==
                               layer_tree_host_->source_frame_number();
 
   layer->SetBackgroundColor(inputs_.background_color);
+  layer->SetFiltersOrigin(inputs_.filters_origin);

[ajuma, 2016/08/29 20:28:43]

This shouldn't be needed (since filters_origin will get pushed with the effect
tree).

[Stephen White, 2016/08/29 21:10:54]

Removed.

   layer->SetSafeOpaqueBackgroundColor(safe_opaque_background_color_);
   layer->SetBounds(use_paint_properties ? paint_properties_.bounds
                                         : inputs_.bounds);
 
 #if defined(NDEBUG)
   if (frame_viewer_instrumentation::IsTracingLayerTreeSnapshots())
     layer->SetDebugInfo(TakeDebugInfo());
 #else
   layer->SetDebugInfo(TakeDebugInfo());
 #endif
@@ skipping 734 matching lines @@
   DCHECK_NE(transform_tree_index_, TransformTree::kInvalidNodeId);
   return draw_property_utils::ScreenSpaceTransform(
       this, layer_tree_->property_trees()->transform_tree);
 }
 
 LayerTree* Layer::GetLayerTree() const {
   return layer_tree_;
 }
 
 }  // namespace cc