Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(502)

Unified Diff: runtime/observatory/lib/src/elements/heap_snapshot.dart

Issue 2278223002: Prevent the allInstances array from creating spurious references on future heap queries. (Closed)
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/vm/service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/observatory/lib/src/elements/heap_snapshot.dart
diff --git a/runtime/observatory/lib/src/elements/heap_snapshot.dart b/runtime/observatory/lib/src/elements/heap_snapshot.dart
index 0b1ffcfdc2c236bff55ae2417b9645451a73136e..0913e1ebdb257784f40a1b1f634caa57f11a01fe 100644
--- a/runtime/observatory/lib/src/elements/heap_snapshot.dart
+++ b/runtime/observatory/lib/src/elements/heap_snapshot.dart
@@ -353,7 +353,7 @@ class HeapSnapshotElement extends HtmlElement implements Renderable {
element.children[3].text = '';
if (item is Iterable<M.HeapSnapshotClassInbound>) {
element.children[4] = new SpanElement()..classes = const ['name']
- ..text = '${item.length} Ingoing references';
+ ..text = '${item.length} Incoming references';
} else {
element.children[4] = new SpanElement()..classes = const ['name']
..text = '${item.length} Outgoing references';
« no previous file with comments | « no previous file | runtime/vm/service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698