Issue 2278223002: Prevent the allInstances array from creating spurious references on future heap queries.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2278223002: Prevent the allInstances array from creating spurious references on future heap queries. (Closed)

Created:
4 years, 3 months ago by rmacnak

Modified:
4 years, 3 months ago

Reviewers:
Cutch

CC:
reviews_dartlang.org, turnidge, Cutch, vm-dev_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Prevent the allInstances array from creating spurious references on future heap queries. Also prevent spurious references to Fields from retaining path's work array. Fixes #27156 R=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/d644dc0661b0762eeb6dc81fba17255a5163e4c6

Created: 4 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -16 lines)			Patch
	M	runtime/observatory/lib/src/elements/heap_snapshot.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	runtime/vm/service.cc	View		3 chunks	+19 lines, -15 lines	0 comments	Download

Total messages: 5 (2 generated)

rmacnak

4 years, 3 months ago (2016-08-25 18:26:24 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
d644dc0661b0762eeb6dc81fba17255a5163e4c6 (presubmit successful).