Rename the global inference task and reduce it's API surface by introducing the

Rename the global inference task and reduce it's API surface by introducing the
CommonMasks class.

R=het@google.com

Committed: https://github.com/dart-lang/sdk/commit/740c3d466af9235b83881fb3a56860e7d1754734

[Siggi Cherem (dart-lang), 2016-08-25 22:30:08]

Patchset #1 (id:1) has been deleted

[Siggi Cherem (dart-lang), 2016-08-25 22:40:16]

Patchset #2 (id:40001) has been deleted

[Siggi Cherem (dart-lang), 2016-08-25 22:40:24]

Patchset #1 (id:20001) has been deleted

[Siggi Cherem (dart-lang), 2016-08-25 22:40:46]

sigmund@google.com changed reviewers:
+ het@google.com

[Harry Terkelsen, 2016-08-25 23:06:25]

lgtm

https://codereview.chromium.org/2278213003/diff/60001/pkg/compiler/lib/src/in...
File pkg/compiler/lib/src/inferrer/type_graph_inferrer.dart (right):

https://codereview.chromium.org/2278213003/diff/60001/pkg/compiler/lib/src/in...
pkg/compiler/lib/src/inferrer/type_graph_inferrer.dart:587: CommonMasks get
commonMasks => compiler.commonMasks;
if you already have the commonMasks as a constructor argument why not just store
it instead of going through compiler?

https://codereview.chromium.org/2278213003/diff/60001/pkg/compiler/lib/src/in...
pkg/compiler/lib/src/inferrer/type_graph_inferrer.dart:1379: if (element is
FunctionElement) return compiler.commonMasks.functionType;
no need for 'compiler' here

https://codereview.chromium.org/2278213003/diff/60001/pkg/compiler/lib/src/in...
File pkg/compiler/lib/src/inferrer/type_graph_nodes.dart (right):

https://codereview.chromium.org/2278213003/diff/60001/pkg/compiler/lib/src/in...
pkg/compiler/lib/src/inferrer/type_graph_nodes.dart:839: return receiverType ==
inferrer.compiler.commonMasks.dynamicType
can this just be 'inferrer.commonMasks' now?

https://codereview.chromium.org/2278213003/diff/60001/pkg/compiler/lib/src/js...
File pkg/compiler/lib/src/js_backend/backend.dart (right):

https://codereview.chromium.org/2278213003/diff/60001/pkg/compiler/lib/src/js...
pkg/compiler/lib/src/js_backend/backend.dart:405: _nonNullTypeCache =
compiler.commonMasks.dynamicType.nonNullable();
just replace compiler.commonMasks.dynamicType with dynamicType?

https://codereview.chromium.org/2278213003/diff/60001/pkg/compiler/lib/src/wo...
File pkg/compiler/lib/src/world.dart (right):

https://codereview.chromium.org/2278213003/diff/60001/pkg/compiler/lib/src/wo...
pkg/compiler/lib/src/world.dart:729: mask = mask == null ?
compiler.commonMasks.dynamicType : mask;
can replace this line with mask ?? = compiler.commonMasks.dynamicType

[Siggi Cherem (dart-lang), 2016-08-25 23:19:33]

thanks!

https://codereview.chromium.org/2278213003/diff/60001/pkg/compiler/lib/src/in...
File pkg/compiler/lib/src/inferrer/type_graph_inferrer.dart (right):

https://codereview.chromium.org/2278213003/diff/60001/pkg/compiler/lib/src/in...
pkg/compiler/lib/src/inferrer/type_graph_inferrer.dart:587: CommonMasks get
commonMasks => compiler.commonMasks;
On 2016/08/25 23:06:25, Harry Terkelsen wrote:
> if you already have the commonMasks as a constructor argument why not just
store
> it instead of going through compiler?

Done.

https://codereview.chromium.org/2278213003/diff/60001/pkg/compiler/lib/src/in...
pkg/compiler/lib/src/inferrer/type_graph_inferrer.dart:1379: if (element is
FunctionElement) return compiler.commonMasks.functionType;
On 2016/08/25 23:06:25, Harry Terkelsen wrote:
> no need for 'compiler' here

Done.

https://codereview.chromium.org/2278213003/diff/60001/pkg/compiler/lib/src/in...
File pkg/compiler/lib/src/inferrer/type_graph_nodes.dart (right):

https://codereview.chromium.org/2278213003/diff/60001/pkg/compiler/lib/src/in...
pkg/compiler/lib/src/inferrer/type_graph_nodes.dart:839: return receiverType ==
inferrer.compiler.commonMasks.dynamicType
On 2016/08/25 23:06:25, Harry Terkelsen wrote:
> can this just be 'inferrer.commonMasks' now?

Done.

https://codereview.chromium.org/2278213003/diff/60001/pkg/compiler/lib/src/js...
File pkg/compiler/lib/src/js_backend/backend.dart (right):

https://codereview.chromium.org/2278213003/diff/60001/pkg/compiler/lib/src/js...
pkg/compiler/lib/src/js_backend/backend.dart:405: _nonNullTypeCache =
compiler.commonMasks.dynamicType.nonNullable();
On 2016/08/25 23:06:25, Harry Terkelsen wrote:
> just replace compiler.commonMasks.dynamicType with dynamicType?

Actually - nonNullType is defined in commonMasks already, I'm now forwarding to
that one instead

https://codereview.chromium.org/2278213003/diff/60001/pkg/compiler/lib/src/wo...
File pkg/compiler/lib/src/world.dart (right):

https://codereview.chromium.org/2278213003/diff/60001/pkg/compiler/lib/src/wo...
pkg/compiler/lib/src/world.dart:729: mask = mask == null ?
compiler.commonMasks.dynamicType : mask;
On 2016/08/25 23:06:25, Harry Terkelsen wrote:
> can replace this line with mask ?? = compiler.commonMasks.dynamicType

Yes we can! :)

[Siggi Cherem (dart-lang), 2016-08-25 23:20:34]

Description was changed from

==========
Rename the global inference task and reduce it's API surface by introducing the
CommonMasks class.
==========

to

==========
Rename the global inference task and reduce it's API surface by introducing the
CommonMasks class.

R=het@google.com

Committed:
https://github.com/dart-lang/sdk/commit/740c3d466af9235b83881fb3a56860e7d1754734
==========

[Siggi Cherem (dart-lang), 2016-08-25 23:20:36]

Committed patchset #2 (id:80001) manually as
740c3d466af9235b83881fb3a56860e7d1754734 (presubmit successful).