DevTools: Allow shadow-editor value manipulation with arrow keys and mousewheel

third_party/WebKit/Source/devtools/front_end/ui/UIUtils.js

 /*
  * Copyright (C) 2011 Google Inc.  All rights reserved.
  * Copyright (C) 2006, 2007, 2008 Apple Inc.  All rights reserved.
  * Copyright (C) 2007 Matt Lilek (pewtermoose@gmail.com).
  * Copyright (C) 2009 Joseph Pecoraro
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
@@ skipping 368 matching lines @@
         if (event.key === "ArrowUp" || event.key === "PageUp")
             direction = "Up";
         else if (event.key === "ArrowDown" || event.key === "PageDown")
             direction = "Down";
     }
     return direction;
 }
 
 /**
  * @param {string} hexString
  * @param {!Event} event

[dgozman, 2016/08/29 17:47:20]

Let's add @return annotation.

[flandy, 2016/08/29 18:47:06]

Done. 

The lack of return annotations here skirted some closure compiler requirements
for customNumberHandler. We only use custom number handlers for regular numbers
and not hex values, so I've updated the code to reflect that.

  */
 WebInspector._modifiedHexValue = function(hexString, event)
 {
     var direction = WebInspector._valueModificationDirection(event);
     if (!direction)
-        return hexString;
+        return null;
 
     var mouseEvent = /** @type {!MouseEvent} */(event);
     var number = parseInt(hexString, 16);
     if (isNaN(number) || !isFinite(number))
-        return hexString;
+        return null;
 
     var hexStrLen = hexString.length;
     var channelLen = hexStrLen / 3;
 
     // Colors are either rgb or rrggbb.
     if (channelLen !== 1 && channelLen !== 2)
-        return hexString;
+        return null;
 
     // Precision modifier keys work with both mousewheel and up/down keys.
     // When ctrl is pressed, increase R by 1.
     // When shift is pressed, increase G by 1.
     // When alt is pressed, increase B by 1.
     // If no shortcut keys are pressed then increase hex value by 1.
     // Keys can be pressed together to increase RGB channels. e.g trying different shades.
     var delta = 0;
     if (WebInspector.KeyboardShortcut.eventHasCtrlOrMeta(mouseEvent))
         delta += Math.pow(16, channelLen * 2);
@@ skipping 18 matching lines @@
 }
 
 /**
  * @param {number} number
  * @param {!Event} event
  */
 WebInspector._modifiedFloatNumber = function(number, event)
 {
     var direction = WebInspector._valueModificationDirection(event);
     if (!direction)
-        return number;
+        return null;
 
     var mouseEvent = /** @type {!MouseEvent} */(event);
 
     // Precision modifier keys work with both mousewheel and up/down keys.
     // When ctrl is pressed, increase by 100.
     // When shift is pressed, increase by 10.
     // When alt is pressed, increase by 0.1.
     // Otherwise increase by 1.
     var delta = 1;
     if (WebInspector.KeyboardShortcut.eventHasCtrlOrMeta(mouseEvent))
@@ skipping 17 matching lines @@
 
 /**
  * @param {string} wordString
  * @param {!Event} event
  * @param {function(string, number, string):string=} customNumberHandler
  * @return {?string}
  */
 WebInspector.createReplacementString = function(wordString, event, customNumberHandler)
 {
     var replacementString;
-    var prefix, suffix, number;
-
+    var prefix = "";
+    var suffix = "";
+    var number = null;
     var matches;
     matches = /(.*#)([\da-fA-F]+)(.*)/.exec(wordString);
     if (matches && matches.length) {
         prefix = matches[1];
         suffix = matches[3];
         number = WebInspector._modifiedHexValue(matches[2], event);
-
-        replacementString = customNumberHandler ? customNumberHandler(prefix, number, suffix) : prefix + number + suffix;
     } else {
         matches = /(.*?)(-?(?:\d+(?:\.\d+)?|\.\d+))(.*)/.exec(wordString);
         if (matches && matches.length) {
             prefix = matches[1];
             suffix = matches[3];
             number = WebInspector._modifiedFloatNumber(parseFloat(matches[2]), event);
-
-            // Need to check for null explicitly.
-            if (number === null)
-                return null;
-
-            replacementString = customNumberHandler ? customNumberHandler(prefix, number, suffix) : prefix + number + suffix;
         }
     }
+    // Need to check for null explicitly.
+    if (number === null)
+        return null;
+    replacementString = customNumberHandler ? customNumberHandler(prefix, number, suffix) : prefix + number + suffix;
     return replacementString || null;
 }
 
 /**
  * @param {!Event} event
  * @param {!Element} element
  * @param {function(string,string)=} finishHandler
  * @param {function(string)=} suggestionHandler
  * @param {function(string, number, string):string=} customNumberHandler
  * @return {boolean}
@@ skipping 1488 matching lines @@
  * @param {string} title
  * @return {!Element}
  */
 WebInspector.linkifyDocumentationURLAsNode = function(article, title)
 {
     return WebInspector.linkifyURLAsNode("https://developers.google.com/web/tools/chrome-devtools/" + article, title, undefined, true);
 }
 
 /** @type {!WebInspector.ThemeSupport} */
 WebInspector.themeSupport;