Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Issue 2278203003: DevTools: Allow shadow-editor value manipulation with arrow keys and mousewheel (Closed)

Created:
4 years, 3 months ago by flandy
Modified:
4 years, 3 months ago
Reviewers:
dgozman, lushnikov
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: Allow shadow-editor value manipulation with arrow keys and mousewheel BUG=639095 Committed: https://crrev.com/b3af58d2e0f9df1e6e625c3d6c3815e5e688f515 Cr-Commit-Position: refs/heads/master@{#415068}

Patch Set 1 #

Patch Set 2 : Don't let blur go below 0 #

Total comments: 4

Patch Set 3 : Check key pressed inside createReplacementString #

Total comments: 2

Patch Set 4 : Add return annotations #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -28 lines) Patch
M third_party/WebKit/Source/devtools/front_end/components/Spectrum.js View 1 2 2 chunks +6 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/CSSShadowEditor.js View 1 2 2 chunks +35 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/UIUtils.js View 1 2 3 3 chunks +16 lines, -18 lines 0 comments Download

Messages

Total messages: 15 (4 generated)
flandy
Please, take a look.
4 years, 3 months ago (2016-08-25 18:05:25 UTC) #2
dgozman
lgtm https://codereview.chromium.org/2278203003/diff/20001/third_party/WebKit/Source/devtools/front_end/ui/CSSShadowEditor.js File third_party/WebKit/Source/devtools/front_end/ui/CSSShadowEditor.js (right): https://codereview.chromium.org/2278203003/diff/20001/third_party/WebKit/Source/devtools/front_end/ui/CSSShadowEditor.js#newcode134 third_party/WebKit/Source/devtools/front_end/ui/CSSShadowEditor.js:134: if (!arrowKeyOrMouseWheelEvent && !pageKeyPressed) Doesn't createReplacementString check this ...
4 years, 3 months ago (2016-08-26 19:10:58 UTC) #3
flandy
https://codereview.chromium.org/2278203003/diff/20001/third_party/WebKit/Source/devtools/front_end/ui/CSSShadowEditor.js File third_party/WebKit/Source/devtools/front_end/ui/CSSShadowEditor.js (right): https://codereview.chromium.org/2278203003/diff/20001/third_party/WebKit/Source/devtools/front_end/ui/CSSShadowEditor.js#newcode134 third_party/WebKit/Source/devtools/front_end/ui/CSSShadowEditor.js:134: if (!arrowKeyOrMouseWheelEvent && !pageKeyPressed) On 2016/08/26 19:10:58, dgozman wrote: ...
4 years, 3 months ago (2016-08-26 19:25:59 UTC) #4
dgozman
https://codereview.chromium.org/2278203003/diff/20001/third_party/WebKit/Source/devtools/front_end/ui/CSSShadowEditor.js File third_party/WebKit/Source/devtools/front_end/ui/CSSShadowEditor.js (right): https://codereview.chromium.org/2278203003/diff/20001/third_party/WebKit/Source/devtools/front_end/ui/CSSShadowEditor.js#newcode134 third_party/WebKit/Source/devtools/front_end/ui/CSSShadowEditor.js:134: if (!arrowKeyOrMouseWheelEvent && !pageKeyPressed) On 2016/08/26 19:25:59, flandy wrote: ...
4 years, 3 months ago (2016-08-26 20:49:35 UTC) #5
flandy
Please take another look. I've moved the check inwards https://codereview.chromium.org/2278203003/diff/20001/third_party/WebKit/Source/devtools/front_end/ui/CSSShadowEditor.js File third_party/WebKit/Source/devtools/front_end/ui/CSSShadowEditor.js (right): https://codereview.chromium.org/2278203003/diff/20001/third_party/WebKit/Source/devtools/front_end/ui/CSSShadowEditor.js#newcode134 third_party/WebKit/Source/devtools/front_end/ui/CSSShadowEditor.js:134: ...
4 years, 3 months ago (2016-08-26 22:19:42 UTC) #6
flandy
Ping
4 years, 3 months ago (2016-08-29 16:53:42 UTC) #7
dgozman
lgtm https://codereview.chromium.org/2278203003/diff/40001/third_party/WebKit/Source/devtools/front_end/ui/UIUtils.js File third_party/WebKit/Source/devtools/front_end/ui/UIUtils.js (right): https://codereview.chromium.org/2278203003/diff/40001/third_party/WebKit/Source/devtools/front_end/ui/UIUtils.js#newcode389 third_party/WebKit/Source/devtools/front_end/ui/UIUtils.js:389: * @param {!Event} event Let's add @return annotation.
4 years, 3 months ago (2016-08-29 17:47:20 UTC) #8
flandy
https://codereview.chromium.org/2278203003/diff/40001/third_party/WebKit/Source/devtools/front_end/ui/UIUtils.js File third_party/WebKit/Source/devtools/front_end/ui/UIUtils.js (right): https://codereview.chromium.org/2278203003/diff/40001/third_party/WebKit/Source/devtools/front_end/ui/UIUtils.js#newcode389 third_party/WebKit/Source/devtools/front_end/ui/UIUtils.js:389: * @param {!Event} event On 2016/08/29 17:47:20, dgozman wrote: ...
4 years, 3 months ago (2016-08-29 18:47:06 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2278203003/60001
4 years, 3 months ago (2016-08-29 23:53:08 UTC) #12
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 3 months ago (2016-08-30 04:02:14 UTC) #13
commit-bot: I haz the power
4 years, 3 months ago (2016-08-30 04:04:35 UTC) #15
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/b3af58d2e0f9df1e6e625c3d6c3815e5e688f515
Cr-Commit-Position: refs/heads/master@{#415068}

Powered by Google App Engine
This is Rietveld 408576698