[NaCl SDK] Teach create_nmf about ARM shared libraries.

[NaCl SDK] Teach create_nmf about ARM shared libraries.

This change is needed to support he bionic toolchain which
can produce shared libraries for ARM.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=262300

[binji, 2014-04-07 20:16:56]

lgtm, with bug referenced.

https://codereview.chromium.org/227813003/diff/20001/native_client_sdk/src/to...
File native_client_sdk/src/tools/create_nmf.py (right):

https://codereview.chromium.org/227813003/diff/20001/native_client_sdk/src/to...
native_client_sdk/src/tools/create_nmf.py:538: ] + libpath
Wouldn't it be safer to include the bionic search paths after the glibc ones?

https://codereview.chromium.org/227813003/diff/20001/native_client_sdk/src/to...
File native_client_sdk/src/tools/lib/get_shared_deps.py (right):

https://codereview.chromium.org/227813003/diff/20001/native_client_sdk/src/to...
native_client_sdk/src/tools/lib/get_shared_deps.py:205: # The libc.so files in
the the glibc toolchain is actually a linker
File a bug for this and reference it here.

[Sam Clegg, 2014-04-07 20:41:35]

https://codereview.chromium.org/227813003/diff/20001/native_client_sdk/src/to...
File native_client_sdk/src/tools/create_nmf.py (right):

https://codereview.chromium.org/227813003/diff/20001/native_client_sdk/src/to...
native_client_sdk/src/tools/create_nmf.py:538: ] + libpath
On 2014/04/07 20:16:56, binji wrote:
> Wouldn't it be safer to include the bionic search paths after the glibc ones?

Done.

https://codereview.chromium.org/227813003/diff/20001/native_client_sdk/src/to...
File native_client_sdk/src/tools/lib/get_shared_deps.py (right):

https://codereview.chromium.org/227813003/diff/20001/native_client_sdk/src/to...
native_client_sdk/src/tools/lib/get_shared_deps.py:205: # The libc.so files in
the the glibc toolchain is actually a linker
On 2014/04/07 20:16:56, binji wrote:
> File a bug for this and reference it here.

Done.

[Sam Clegg, 2014-04-07 20:41:43]

The CQ bit was checked by sbc@chromium.org

[commit-bot: I haz the power, 2014-04-07 20:49:33]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sbc@chromium.org/227813003/20001

[Sam Clegg, 2014-04-07 22:21:58]

The CQ bit was checked by sbc@chromium.org

[commit-bot: I haz the power, 2014-04-07 22:23:45]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sbc@chromium.org/227813003/40001

[commit-bot: I haz the power, 2014-04-08 04:09:56]

Change committed as 262300