Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2278113002:
Temporarily remove chrome_app_unittests from the Dr. Memory builder (Closed)
|
Created:
4 years, 3 months ago by Alexander Potapenko Modified:
4 years, 3 months ago Reviewers:
Dirk Pranke CC:
chromium-reviews Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionTemporarily remove chrome_app_unittests from the Dr. Memory builder
BUG=640185
TBR=dpranke@chromium.org
NOTRY=true
Committed: https://crrev.com/ad1aac65be3a92db6e76bf62336569ee65246666
Cr-Commit-Position: refs/heads/master@{#414420}
Patch Set 1 #
Messages
Total messages: 20 (8 generated)
TBR Trying to figure out what's wrong with the bot.
The CQ bit was checked by glider@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by glider@chromium.org
Description was changed from ========== Temporarily remove chrome_app_unittests from the Dr. Memory builder BUG=640185 TBR=dpranke@chromium.org ========== to ========== Temporarily remove chrome_app_unittests from the Dr. Memory builder BUG=640185 TBR=dpranke@chromium.org NOTRY=true ==========
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
On 2016/08/25 13:39:24, commit-bot: I haz the power wrote: > Try jobs failed on following builders: > linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, > https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...) Don't think we need tryjobs here.
The CQ bit was unchecked by glider@chromium.org
The CQ bit was checked by glider@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Temporarily remove chrome_app_unittests from the Dr. Memory builder BUG=640185 TBR=dpranke@chromium.org NOTRY=true ========== to ========== Temporarily remove chrome_app_unittests from the Dr. Memory builder BUG=640185 TBR=dpranke@chromium.org NOTRY=true ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Temporarily remove chrome_app_unittests from the Dr. Memory builder BUG=640185 TBR=dpranke@chromium.org NOTRY=true ========== to ========== Temporarily remove chrome_app_unittests from the Dr. Memory builder BUG=640185 TBR=dpranke@chromium.org NOTRY=true Committed: https://crrev.com/ad1aac65be3a92db6e76bf62336569ee65246666 Cr-Commit-Position: refs/heads/master@{#414420} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/ad1aac65be3a92db6e76bf62336569ee65246666 Cr-Commit-Position: refs/heads/master@{#414420}
Message was sent while issue was closed.
lgtm
Message was sent while issue was closed.
On 2016/08/25 15:57:26, Dirk Pranke wrote: > lgtm Hm, according to https://build.chromium.org/p/chromium.memory.full/builders/Chromium%20Windows... it's still trying to build chrome_app_unittests, am I doing something wrong?
Message was sent while issue was closed.
On 2016/08/25 17:25:51, Alexander Potapenko wrote: > On 2016/08/25 15:57:26, Dirk Pranke wrote: > > lgtm > > Hm, according to > https://build.chromium.org/p/chromium.memory.full/builders/Chromium%20Windows... > it's still trying to build chrome_app_unittests, am I doing something wrong? chrome_app_unittests is listed as part of the chromium_builder_dbg_drmemory_win compile target (in //BUILD.gn) so we're still going to try and build it, even if we don't run the test. You would need to comment it out from that target as well. Ideally we'd get rid of the chromiuM_builder_dbg_drmemory_win target and just build things based on which targets we're actually running, but since a lot of the tests are currently disabled, that might lose even more coverage (though, if we think it's unlikely that we'll get drmem-specific compile failures, maybe that's not a big concern).
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2347223002/ by tommycli@chromium.org. The reason for reverting is: Reverting, because Dr. Memory test bots need that executable. It didn't break until a clobber landed and deleted the executable generated in the past. Also glider@ reports that chrome_app_unittests was probably innocent (in the bug report) anyways. First breaking build: https://build.chromium.org/p/chromium.memory.full/builders/Windows%20Unit%20%.... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
