Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(367)

Issue 2278103002: Include only stuff you need, part 5: make function-tester.h slimmer. (Closed)

Created:
4 years, 3 months ago by marja
Modified:
4 years, 3 months ago
Reviewers:
Michael Starzinger
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Include only stuff you need, part 5: make function-tester.h slimmer. Rebuilding (after touching certain files) is crazy slow because includes are out of control. Many of these files we need to rebuild are cctests which pull in more includes than they need. BUG=v8:5294 Committed: https://crrev.com/fc6425c56ac6630b08000f98daf0549a8b3296e7 Cr-Commit-Position: refs/heads/master@{#38933}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+219 lines, -146 lines) Patch
M test/cctest/cctest.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/compiler/function-tester.h View 4 chunks +28 lines, -146 lines 0 comments Download
A test/cctest/compiler/function-tester.cc View 1 chunk +183 lines, -0 lines 0 comments Download
M test/cctest/compiler/test-code-assembler.cc View 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/compiler/test-run-inlining.cc View 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/compiler/test-run-intrinsics.cc View 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/compiler/test-run-stubs.cc View 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/test-code-stub-assembler.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
Michael Starzinger
LGTM. Nice!
4 years, 3 months ago (2016-08-26 08:37:56 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2278103002/1
4 years, 3 months ago (2016-08-26 08:39:02 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-26 08:41:29 UTC) #9
commit-bot: I haz the power
4 years, 3 months ago (2016-08-26 08:41:47 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fc6425c56ac6630b08000f98daf0549a8b3296e7
Cr-Commit-Position: refs/heads/master@{#38933}

Powered by Google App Engine
This is Rietveld 408576698