Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(469)

Issue 2278043002: [turbofan] Add regression tests for LoadElement/Field in diamond. (Closed)

Created:
4 years, 4 months ago by Benedikt Meurer
Modified:
4 years, 4 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Add regression tests for LoadElement/Field in diamond. This introduces appropriate unit tests to ensure that merging of elements/fields information is correct for diamonds. BUG=chromium:639210, v8:5266 R=jarin@chromium.org Committed: https://crrev.com/a124bf773fe1c5140d0a2e8849ffbc2246bc53fe Cr-Commit-Position: refs/heads/master@{#38881}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+146 lines, -0 lines) Patch
M test/unittests/compiler/load-elimination-unittest.cc View 1 chunk +146 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
Benedikt Meurer
4 years, 4 months ago (2016-08-25 03:36:12 UTC) #1
Benedikt Meurer
Hey Jaro, Some unittests to increase confidence in LoadEliminations correctness (esp. since asm.js is hopefully ...
4 years, 4 months ago (2016-08-25 03:37:28 UTC) #4
Jarin
lgtm
4 years, 4 months ago (2016-08-25 05:00:55 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2278043002/1
4 years, 4 months ago (2016-08-25 05:06:37 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-25 05:08:59 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-08-25 05:09:33 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a124bf773fe1c5140d0a2e8849ffbc2246bc53fe
Cr-Commit-Position: refs/heads/master@{#38881}

Powered by Google App Engine
This is Rietveld 408576698