Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(362)

Issue 2278033003: Revert of Add POINTER_TYPE_ERASER to EventPointerType (Closed)

Created:
4 years, 4 months ago by msw
Modified:
4 years, 4 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, kalyank, ozone-reviews_chromium.org, tdresser+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add POINTER_TYPE_ERASER to EventPointerType (patchset #5 id:80001 of https://codereview.chromium.org/2235933002/ ) Reason for revert: Broke the build: https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Builder/builds/45081/steps/compile/logs/stdio ../../ash/wm/stylus_metrics_recorder.cc:62:11: error: enumeration value 'POINTER_TYPE_ERASER' not handled in switch [-Werror,-Wswitch] Original issue's description: > Add POINTER_TYPE_ERASER to EventPointerType > > This pointer type can be used by graphics tablets, frequently the > back-side of a stylus. > > BUG=636458 > TEST=Use rubber tool and watch generated mouse events. > > Committed: https://crrev.com/b90b789aea11dd97a7daa98bec8dd96d2f89f205 > Cr-Commit-Position: refs/heads/master@{#414146} TBR=reveman@chromium.org,sadrul@chromium.org,spang@chromium.org,denniskempin@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=636458 Committed: https://crrev.com/1b5cbeede045eaec39b9bcee18ba31ede8035393 Cr-Commit-Position: refs/heads/master@{#414310}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -19 lines) Patch
M components/exo/wayland/server.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/events/blink/web_input_event.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ui/events/event_constants.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/events/gestures/motion_event_aura.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/events/ozone/evdev/tablet_event_converter_evdev.cc View 3 chunks +2 lines, -8 lines 0 comments Download
M ui/events/ozone/evdev/touch_event_converter_evdev.cc View 3 chunks +0 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
msw
Created Revert of Add POINTER_TYPE_ERASER to EventPointerType
4 years, 4 months ago (2016-08-25 04:39:33 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2278033003/1
4 years, 4 months ago (2016-08-25 04:40:06 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-25 04:40:54 UTC) #5
commit-bot: I haz the power
4 years, 4 months ago (2016-08-25 04:42:44 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1b5cbeede045eaec39b9bcee18ba31ede8035393
Cr-Commit-Position: refs/heads/master@{#414310}

Powered by Google App Engine
This is Rietveld 408576698