ContentView->ContentViewCore in ContentViewRenderView

ContentView->ContentViewCore in ContentViewRenderView

ContentViewRenderView's usage of ContentView is historical. Everything
just forwards to ContentViewCore. Cleaning this up, allows further
distinction between the two.

Some misc changes in TabUtils.java to appease presubmit.

BUG=360664
Use CVC as appropriate in content shell

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=262838

[Yaron, 2014-04-07 18:48:32]

https://codereview.chromium.org/227803004/diff/20001/chrome/android/shell/jav...
File
chrome/android/shell/javatests/src/org/chromium/chrome/shell/ChromeShellUrlTest.java
(right):

https://codereview.chromium.org/227803004/diff/20001/chrome/android/shell/jav...
chrome/android/shell/javatests/src/org/chromium/chrome/shell/ChromeShellUrlTest.java:108:
activity.getActiveContentView().getContentViewCore());
I have plans to remove the extra hop |getContentViewCore| here. This is just
temporary to keep it small.

https://codereview.chromium.org/227803004/diff/20001/content/shell/android/ja...
File content/shell/android/java/src/org/chromium/content_shell/ShellManager.java
(right):

https://codereview.chromium.org/227803004/diff/20001/content/shell/android/ja...
content/shell/android/java/src/org/chromium/content_shell/ShellManager.java:157:
contentView.getContentViewCore().onShow();
Oops. this bled in. No harm though for fixing now.

[Yaron, 2014-04-08 18:21:29]

On 2014/04/07 18:48:32, Yaron wrote:
>
https://codereview.chromium.org/227803004/diff/20001/chrome/android/shell/jav...
> File
>
chrome/android/shell/javatests/src/org/chromium/chrome/shell/ChromeShellUrlTest.java
> (right):
> 
>
https://codereview.chromium.org/227803004/diff/20001/chrome/android/shell/jav...
>
chrome/android/shell/javatests/src/org/chromium/chrome/shell/ChromeShellUrlTest.java:108:
> activity.getActiveContentView().getContentViewCore());
> I have plans to remove the extra hop |getContentViewCore| here. This is just
> temporary to keep it small.
> 
>
https://codereview.chromium.org/227803004/diff/20001/content/shell/android/ja...
> File
content/shell/android/java/src/org/chromium/content_shell/ShellManager.java
> (right):
> 
>
https://codereview.chromium.org/227803004/diff/20001/content/shell/android/ja...
>
content/shell/android/java/src/org/chromium/content_shell/ShellManager.java:157:
> contentView.getContentViewCore().onShow();
> Oops. this bled in. No harm though for fixing now.

friendly ping

[Yaron, 2014-04-09 16:55:08]

dtrain, care to take a look?

[David Trainor- moved to gerrit, 2014-04-09 17:18:08]

lgtm

[Yaron, 2014-04-09 17:19:52]

The CQ bit was checked by yfriedman@chromium.org

[commit-bot: I haz the power, 2014-04-09 17:20:09]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yfriedman@chromium.org/227803004/20001

[commit-bot: I haz the power, 2014-04-09 22:19:30]

Change committed as 262838