Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(915)

Unified Diff: chrome/browser/safe_browsing/srt_fetcher_win.h

Issue 2278013002: Add support for the ExperimentalSwReporterEngine field trial. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/safe_browsing/srt_fetcher_win.h
diff --git a/chrome/browser/safe_browsing/srt_fetcher_win.h b/chrome/browser/safe_browsing/srt_fetcher_win.h
index 6339a001345400ee5d80d764069d565d4c82843d..d1a8872065e341e299c68b63a7a290a21a97e675 100644
--- a/chrome/browser/safe_browsing/srt_fetcher_win.h
+++ b/chrome/browser/safe_browsing/srt_fetcher_win.h
@@ -45,6 +45,15 @@ const int kDaysBetweenSwReporterRunsForPendingPrompt = 1;
struct SwReporterInvocation {
base::CommandLine command_line;
+ // Experimental versions of the reporter will write metrics to registry keys
+ // ending in |suffix|. Those metrics should be copied to UMA histograms also
+ // ending in |suffix|. For the canonical version, |suffix| will be empty.
+ std::string suffix;
+
+ // The experimental sw_reporter never triggers the prompt, just reports
+ // results through UMA.
+ bool is_experimental = false;
+
SwReporterInvocation();
static SwReporterInvocation FromFilePath(const base::FilePath& exe_path);

Powered by Google App Engine
This is Rietveld 408576698