Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1088)

Unified Diff: chrome/browser/component_updater/sw_reporter_installer_win.h

Issue 2278013002: Add support for the ExperimentalSwReporterEngine field trial. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/component_updater/sw_reporter_installer_win.h
diff --git a/chrome/browser/component_updater/sw_reporter_installer_win.h b/chrome/browser/component_updater/sw_reporter_installer_win.h
index 7427e5a994258c2ae34bdd31839ced2898ceac66..ea4fcb3ea1b95db45fbea039350c2d5bba963387 100644
--- a/chrome/browser/component_updater/sw_reporter_installer_win.h
+++ b/chrome/browser/component_updater/sw_reporter_installer_win.h
@@ -42,12 +42,10 @@ using SwReporterRunner =
class SwReporterInstallerTraits : public ComponentInstallerTraits {
public:
- explicit SwReporterInstallerTraits(const SwReporterRunner& reporter_runner);
+ SwReporterInstallerTraits(const SwReporterRunner& reporter_runner,
+ bool is_experimental_engine_supported);
~SwReporterInstallerTraits() override;
- private:
- friend class SwReporterInstallerTest;
-
// ComponentInstallerTraits implementation.
bool VerifyInstallation(const base::DictionaryValue& manifest,
const base::FilePath& dir) const override;
@@ -64,7 +62,13 @@ class SwReporterInstallerTraits : public ComponentInstallerTraits {
update_client::InstallerAttributes GetInstallerAttributes() const override;
std::vector<std::string> GetMimeTypes() const override;
+ private:
+ friend class SwReporterInstallerTest;
+
+ bool IsExperimentalEngineEnabled() const;
grt (UTC plus 2) 2016/08/25 15:42:13 // Returns true if the experimental engine is supp
Joe Mason 2016/08/25 17:52:59 Done.
+
SwReporterRunner reporter_runner_;
+ bool is_experimental_engine_supported_;
Sorin Jianu 2016/08/25 03:04:29 can this be const?
Joe Mason 2016/08/25 15:50:05 Done.
DISALLOW_COPY_AND_ASSIGN(SwReporterInstallerTraits);
};

Powered by Google App Engine
This is Rietveld 408576698