bluetooth: Fix layering violation in BluetoothChooserController

bluetooth: Fix layering violation in BluetoothChooserController

BluetoothChooserController, which is in chrome/, was including BluetoothMetrics
which is in content/. To avoid this we create a new histogram specifically
for interactions with the chooser.

BUG=641105
Committed: https://crrev.com/2d924f0d278c6edee2872427b89a2f44a6fb0781
Cr-Commit-Position: refs/heads/master@{#414758}

[ortuno, 2016-08-25 21:37:11]

The CQ bit was checked by ortuno@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-25 21:38:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ortuno, 2016-08-25 21:43:45]

The CQ bit was checked by ortuno@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-25 21:44:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ortuno, 2016-08-25 21:44:45]

ortuno@chromium.org changed reviewers:
+ jyasskin@chromium.org

[ortuno, 2016-08-25 21:44:45]

jyasskin: PTAL

[Jeffrey Yasskin, 2016-08-25 21:52:57]

jyasskin@chromium.org changed reviewers:
+ isherman@chromium.org

[Jeffrey Yasskin, 2016-08-25 21:52:57]

This lgtm, but I think we'd also be fine collecting just the count of invalid
interactions, which we're trying to drive to 0. Ilya, as one of the histogram
owners, do you have a preference?

[commit-bot: I haz the power, 2016-08-25 23:06:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-25 23:07:00]

Dry run: This issue passed the CQ dry run.

[Ilya Sherman, 2016-08-26 00:17:44]

There's little implementation overhead to recording valid as well as invalid
cases, so I'd recommend recording both.  That way, you can see whether the raw
numbers are being driven to zero; and also get a baselined view.

https://codereview.chromium.org/2278003003/diff/60001/chrome/browser/ui/bluet...
File chrome/browser/ui/bluetooth/bluetooth_chooser_controller.cc (right):

https://codereview.chromium.org/2278003003/diff/60001/chrome/browser/ui/bluet...
chrome/browser/ui/bluetooth/bluetooth_chooser_controller.cc:34:
UMA_HISTOGRAM_ENUMERATION(
nit: UMA_HISTOGRAM_BOOLEAN probably is the best choice for this use.

https://codereview.chromium.org/2278003003/diff/60001/tools/metrics/histogram...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/2278003003/diff/60001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:96859: +<enum
name="WebBluetoothChooserInteractionType" type="int">
nit: I'd name this "BooleanInvalid"

[Ilya Sherman, 2016-08-26 00:25:51]

Whoops, meant to also say LGTM (% nits).

[ortuno, 2016-08-26 16:14:36]

The CQ bit was checked by ortuno@chromium.org

[ortuno, 2016-08-26 16:14:36]

Thanks!

https://codereview.chromium.org/2278003003/diff/60001/chrome/browser/ui/bluet...
File chrome/browser/ui/bluetooth/bluetooth_chooser_controller.cc (right):

https://codereview.chromium.org/2278003003/diff/60001/chrome/browser/ui/bluet...
chrome/browser/ui/bluetooth/bluetooth_chooser_controller.cc:34:
UMA_HISTOGRAM_ENUMERATION(
On 2016/08/26 at 00:17:44, Ilya Sherman wrote:
> nit: UMA_HISTOGRAM_BOOLEAN probably is the best choice for this use.

Done.

https://codereview.chromium.org/2278003003/diff/60001/tools/metrics/histogram...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/2278003003/diff/60001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:96859: +<enum
name="WebBluetoothChooserInteractionType" type="int">
On 2016/08/26 at 00:17:44, Ilya Sherman wrote:
> nit: I'd name this "BooleanInvalid"

Done.

[ortuno, 2016-08-26 16:14:37]

The patchset sent to the CQ was uploaded after l-g-t-m from
jyasskin@chromium.org, isherman@chromium.org
Link to the patchset: https://codereview.chromium.org/2278003003/#ps80001
(title: "Address isherman's comments")

[commit-bot: I haz the power, 2016-08-26 16:15:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-26 18:43:56]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-08-26 19:16:10]

Description was changed from

==========
bluetooth: Fix layering violation in BluetoothChooserController

BluetoothChooserController, which is in chrome/, was including BluetoothMetrics
which is in content/. To avoid this we create a new histogram specifically
for interactions with the chooser.

BUG=641105
==========

to

==========
bluetooth: Fix layering violation in BluetoothChooserController

BluetoothChooserController, which is in chrome/, was including BluetoothMetrics
which is in content/. To avoid this we create a new histogram specifically
for interactions with the chooser.

BUG=641105

Committed: https://crrev.com/2d924f0d278c6edee2872427b89a2f44a6fb0781
Cr-Commit-Position: refs/heads/master@{#414758}
==========

[commit-bot: I haz the power, 2016-08-26 19:16:12]

Patchset 5 (id:??) landed as
https://crrev.com/2d924f0d278c6edee2872427b89a2f44a6fb0781
Cr-Commit-Position: refs/heads/master@{#414758}