chrome/browser/resources/settings/people_page/password_prompt_dialog.html - Issue 2277993002: Small fixes for the lock screen md-settings page.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/people_page/password_prompt_dialog.html

Issue 2277993002: Small fixes for the lock screen md-settings page. (Closed)

Patch Set: Address comments Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.html ('k') | chrome/browser/resources/settings/people_page/password_prompt_dialog.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/people_page/password_prompt_dialog.html

diff --git a/chrome/browser/resources/settings/people_page/password_prompt_dialog.html b/chrome/browser/resources/settings/people_page/password_prompt_dialog.html

index 8221eff3e19efa2766bb4bb47290a6074b02c9f4..5f893f8ea0b534cbf03e23661330f0d9a71bd91e 100644

--- a/chrome/browser/resources/settings/people_page/password_prompt_dialog.html

+++ b/chrome/browser/resources/settings/people_page/password_prompt_dialog.html

@@ -17,7 +17,7 @@

}

</style>

- <dialog is="cr-dialog" id="dialog">

+ <dialog is="cr-dialog" id="dialog" on-close="onClose_">

<div class="title">$i18n{passwordPromptTitle}</div>

@@ -27,18 +27,18 @@

label="$i18n{passwordPromptPasswordLabel}"

no-label-float

value="{{password_}}"

- on-change="checkPassword_"

+ on-keydown="onKeydown_"

invalid$="[[passwordInvalid_]]"

error-message="$i18n{passwordPromptInvalidPassword}"

aria-disabled="false">

</paper-input>

- <paper-button class="cancel-button" on-tap="cancel">

+ <paper-button class="cancel-button" on-tap="onCancelTap_">

$i18n{cancel}

</paper-button>

- <paper-button class="action-button" on-tap="checkPassword_"

+ <paper-button class="action-button" on-tap="submitPassword_"

disabled$="[[!enableConfirm_(password_,

passwordInvalid_)]]">

$i18n{confirm}