Small fixes for the lock screen md-settings page.

chrome/browser/resources/settings/people_page/password_prompt_dialog.js

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview
  *
  * 'settings-password-prompt-dialog' shows a dialog which asks for the user to
  * enter their password. It validates the password is correct. Once the user has
  * entered their account password, the page fires an 'authenticated' event and
@@ skipping 72 matching lines @@
    * opening it.
    */
   open: function() {
     // Wait until the dialog is attached to the DOM before trying to open it.
     var dialog = /** @type {{isConnected: boolean}} */ (this.$.dialog);
     if (!dialog.isConnected) {
       setTimeout(this.open.bind(this));
       return;
     }
 
+    if (this.$.dialog.open)
+      return;
+
     this.$.dialog.showModal();
   },
 
-  /** Close the dialog. */
-  close: function() {
+  /** @private */
+  onCancelTap_: function() {
     if (this.$.dialog.open)
       this.$.dialog.close();
 
     this.password_ = '';
   },
 
-  /** Cancel the password prompt. */
-  cancel: function() {
-    if (this.$.dialog.open)
-      this.$.dialog.cancel();
-
-    // We bind setModes_ in an on-change event, so when the user hits cancel
-    // after they enter their valid password we may have authenticated them.
-    this.setModes_ = undefined;
+  /** @private */
+  onKeydown_: function(e) {
+    if (e.key == 'Enter')
+      this.checkPassword_();
   },
 
   /**
    * Run the account password check.
    * @private
    */
   checkPassword_: function() {

[tommycli, 2016/08/25 23:35:21]

One more thing: It would be good to change this to submitPassword_ since that's
the new meaning right? and updated comment too about it closing the dialog

[jdufault, 2016/08/25 23:45:39]

Done.

     clearTimeout(this.clearAccountPasswordTimeout_);
 
     // The user might have started entering a password and then deleted it all.
     // Do not submit/show an error in this case.
     if (!this.password_) {
       this.passwordInvalid_ = false;
       return;
     }
 
     function onPasswordChecked(valid) {
       // The password might have been cleared during the duration of the
       // getActiveModes call.
       this.passwordInvalid_ = !valid && !!this.password_;
 
       if (valid) {
         // Create the |this.setModes| closure and automatically clear it after
         // |PASSWORD_ACTIVE_DURATION_MS|.
         var password = this.password_;
         this.password_ = '';
 
         this.setModes = function(modes, credentials, onComplete) {
           chrome.quickUnlockPrivate.setModes(
               password, modes, credentials, onComplete);
         };
 
         function clearSetModes() {
           // Reset the password so that any cached references to this.setModes
           // will fail.
           password = '';

[tommycli, 2016/08/25 23:34:25]

err... does this actually do anything? I assume you want to clear the
this.password_ variable immediately and not in this timeout right?

[jdufault, 2016/08/25 23:45:39]

This makes it so that calling the closure from a stored variable will fail.
this.password_ has been cleared a long time ago.

           this.setModes = null;
         }
 
         this.clearAccountPasswordTimeout_ = setTimeout(
           clearSetModes.bind(this), PASSWORD_ACTIVE_DURATION_MS);
-        this.close();
+        this.$.dialog.close();

[tommycli, 2016/08/25 23:34:25]

You no longer wish to clear the password_ member variable here?

[jdufault, 2016/08/25 23:45:39]

Added clarifying comment.

       }
     }
 
     checkAccountPassword_(this.password_, onPasswordChecked.bind(this));
   },
 
   /** @private */
   onPasswordChanged_: function() {
     this.passwordInvalid_ = false;
   },
 
   /** @private */
   enableConfirm_: function() {
     return !!this.password_ && !this.passwordInvalid_;
   }
 });
 
 })();