Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(817)

Unified Diff: net/quic/chromium/quic_stream_factory.cc

Issue 2277953002: Fixes use-after-free with Server Migration (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@home
Patch Set: Removed DVLOG Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/chromium/quic_stream_factory.h ('k') | net/quic/chromium/quic_stream_factory_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/chromium/quic_stream_factory.cc
diff --git a/net/quic/chromium/quic_stream_factory.cc b/net/quic/chromium/quic_stream_factory.cc
index c1711985e4887f72c074fed495d30288e0ef9c06..3035f83ebed4bf048d70a7e4adf6bf07c50152f9 100644
--- a/net/quic/chromium/quic_stream_factory.cc
+++ b/net/quic/chromium/quic_stream_factory.cc
@@ -1262,10 +1262,12 @@ void QuicStreamFactory::OnSessionGoingAway(QuicChromiumClientSession* session) {
}
ProcessGoingAwaySession(session, all_sessions_[session].server_id(), false);
if (!aliases.empty()) {
- const IPEndPoint peer_address = session->connection()->peer_address();
+ DCHECK(base::ContainsKey(session_peer_ip_, session));
+ const IPEndPoint peer_address = session_peer_ip_[session];
ip_aliases_[peer_address].erase(session);
if (ip_aliases_[peer_address].empty())
ip_aliases_.erase(peer_address);
+ session_peer_ip_.erase(session);
}
session_aliases_.erase(session);
}
@@ -1877,6 +1879,8 @@ void QuicStreamFactory::ActivateSession(const QuicSessionKey& key,
const IPEndPoint peer_address = session->connection()->peer_address();
DCHECK(!base::ContainsKey(ip_aliases_[peer_address], session));
ip_aliases_[peer_address].insert(session);
+ DCHECK(!base::ContainsKey(session_peer_ip_, session));
+ session_peer_ip_[session] = peer_address;
}
int64_t QuicStreamFactory::GetServerNetworkStatsSmoothedRttInMicroseconds(
« no previous file with comments | « net/quic/chromium/quic_stream_factory.h ('k') | net/quic/chromium/quic_stream_factory_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698