Update Crashpad to b35ee1fca18956f3c27ba124d6dc456a723c7670

Update Crashpad to b35ee1fca18956f3c27ba124d6dc456a723c7670

660a5e69d661 win: switch crashpad_handler.exe to /subsystem:windows and
             add .com
b35ee1fca189 Adding support for on-demand uploads

Committed: https://crrev.com/2d0070cefc5486ad17cf7cedd5ef26612a174b84
Cr-Commit-Position: refs/heads/master@{#414619}

[gayane -on leave until 09-2017, 2016-08-24 22:09:42]

gayane@chromium.org changed reviewers:
+ mark@chromium.org

[gayane -on leave until 09-2017, 2016-08-24 22:09:43]

PTAL

[Mark Mentovai, 2016-08-24 22:12:32]

LGTM

https://codereview.chromium.org/2277943002/diff/1/third_party/crashpad/crashp...
File third_party/crashpad/crashpad/handler/handler.gyp (right):

https://codereview.chromium.org/2277943002/diff/1/third_party/crashpad/crashp...
third_party/crashpad/crashpad/handler/handler.gyp:106: # Duplicates
crashpad_handler.exe to crashpad_handler.com and makes it
Cc scottmg. I don’t think we need to duplicate this in Chrome’s .gn files for
Crashpad because we don’t use crashpad_handler.exe in Chrome anyway, but he’ll
check me on this.

[scottmg, 2016-08-24 22:55:49]

scottmg@chromium.org changed reviewers:
+ scottmg@chromium.org

[scottmg, 2016-08-24 22:55:50]

https://codereview.chromium.org/2277943002/diff/1/third_party/crashpad/crashp...
File third_party/crashpad/crashpad/handler/handler.gyp (right):

https://codereview.chromium.org/2277943002/diff/1/third_party/crashpad/crashp...
third_party/crashpad/crashpad/handler/handler.gyp:106: # Duplicates
crashpad_handler.exe to crashpad_handler.com and makes it
On 2016/08/24 22:12:32, Mark Mentovai wrote:
> Cc scottmg. I don’t think we need to duplicate this in Chrome’s .gn files for
> Crashpad because we don’t use crashpad_handler.exe in Chrome anyway, but he’ll
> check me on this.

Right, no need.

[gayane -on leave until 09-2017, 2016-08-24 23:16:14]

The CQ bit was checked by gayane@chromium.org

[commit-bot: I haz the power, 2016-08-24 23:17:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-25 00:58:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-25 00:58:17]

Try jobs failed on following builders:
  win_clang on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[Mark Mentovai, 2016-08-25 12:51:46]

Based on the commit queue failure, I think we need to edit
build/secondary/third_party/crashpad/crashpad/handler/BUILD.gn to add to the
crashpad_handler target:

if (is_win) {
  ldflags = [
    "/SUBSYSTEM:WINDOWS",
  ]
}

[scottmg, 2016-08-25 15:54:59]

On 2016/08/25 12:51:46, Mark Mentovai wrote:
> Based on the commit queue failure, I think we need to edit
> build/secondary/third_party/crashpad/crashpad/handler/BUILD.gn to add to the
> crashpad_handler target:
> 
> if (is_win) {
>   ldflags = [
>     "/SUBSYSTEM:WINDOWS",
>   ]
> }

Oh, shoot yes, of course. win-clang is the only bot that builds "all".

[Mark Mentovai, 2016-08-25 16:11:22]

https://codereview.chromium.org/2277943002/diff/20001/build/secondary/third_p...
File build/secondary/third_party/crashpad/crashpad/handler/BUILD.gn (right):

https://codereview.chromium.org/2277943002/diff/20001/build/secondary/third_p...
build/secondary/third_party/crashpad/crashpad/handler/BUILD.gn:59: if (is_win) {
This didn’t seem to work. Maybe we need something more like
https://chromium.googlesource.com/chromium/src/+/366d572053dd85c8eeda802f4237...

The GN build is new, I’m not 100% sure which of these recipes applies in this
case.

[gayane -on leave until 09-2017, 2016-08-25 18:07:56]

It works with this last change. Could you double check that the logic is what is
intended ?

[Mark Mentovai, 2016-08-25 18:10:28]

LGTM

https://codereview.chromium.org/2277943002/diff/60001/build/secondary/third_p...
File build/secondary/third_party/crashpad/crashpad/handler/BUILD.gn (right):

https://codereview.chromium.org/2277943002/diff/60001/build/secondary/third_p...
build/secondary/third_party/crashpad/crashpad/handler/BUILD.gn:60: configs -= [
"//build/config/win:console" ]
I don’t know if an import is needed to be able to do this (maybe Scott knows),
but I guess if it works, the import isn’t necessary.

[scottmg, 2016-08-25 18:14:10]

https://codereview.chromium.org/2277943002/diff/60001/build/secondary/third_p...
File build/secondary/third_party/crashpad/crashpad/handler/BUILD.gn (right):

https://codereview.chromium.org/2277943002/diff/60001/build/secondary/third_p...
build/secondary/third_party/crashpad/crashpad/handler/BUILD.gn:60: configs -= [
"//build/config/win:console" ]
On 2016/08/25 18:10:28, Mark Mentovai wrote:
> I don’t know if an import is needed to be able to do this (maybe Scott knows),
> but I guess if it works, the import isn’t necessary.

I think as that config is in a .gn (not .gni) it's OK without.

[gayane -on leave until 09-2017, 2016-08-25 18:32:29]

On 2016/08/25 18:14:10, scottmg wrote:
>
https://codereview.chromium.org/2277943002/diff/60001/build/secondary/third_p...
> File build/secondary/third_party/crashpad/crashpad/handler/BUILD.gn (right):
> 
>
https://codereview.chromium.org/2277943002/diff/60001/build/secondary/third_p...
> build/secondary/third_party/crashpad/crashpad/handler/BUILD.gn:60: configs -=
[
> "//build/config/win:console" ]
> On 2016/08/25 18:10:28, Mark Mentovai wrote:
> > I don’t know if an import is needed to be able to do this (maybe Scott
knows),
> > but I guess if it works, the import isn’t necessary.
> 
> I think as that config is in a .gn (not .gni) it's OK without.

If no objections I am commit the CL like this.

[Mark Mentovai, 2016-08-25 18:49:12]

Go right ahead!

[gayane -on leave until 09-2017, 2016-08-25 18:51:17]

The CQ bit was checked by gayane@chromium.org

[commit-bot: I haz the power, 2016-08-25 18:51:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-25 20:24:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-25 20:24:10]

Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[gayane -on leave until 09-2017, 2016-08-26 00:55:01]

The CQ bit was checked by gayane@chromium.org

[commit-bot: I haz the power, 2016-08-26 00:55:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-26 01:34:53]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-08-26 01:37:02]

Description was changed from

==========
Update Crashpad to b35ee1fca18956f3c27ba124d6dc456a723c7670

660a5e69d661 win: switch crashpad_handler.exe to /subsystem:windows and
             add .com
b35ee1fca189 Adding support for on-demand uploads
==========

to

==========
Update Crashpad to b35ee1fca18956f3c27ba124d6dc456a723c7670

660a5e69d661 win: switch crashpad_handler.exe to /subsystem:windows and
             add .com
b35ee1fca189 Adding support for on-demand uploads

Committed: https://crrev.com/2d0070cefc5486ad17cf7cedd5ef26612a174b84
Cr-Commit-Position: refs/heads/master@{#414619}
==========

[commit-bot: I haz the power, 2016-08-26 01:37:03]

Patchset 4 (id:??) landed as
https://crrev.com/2d0070cefc5486ad17cf7cedd5ef26612a174b84
Cr-Commit-Position: refs/heads/master@{#414619}