Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Issue 2277923002: Attempt 2 at enabling a tab dragging test (Closed)

Created:
4 years, 3 months ago by sky
Modified:
4 years, 3 months ago
Reviewers:
oshima
CC:
chromium-reviews, tfarina, dcheng
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Attempt 2 at enabling a tab dragging test This was reverted because of flake on linux. I've identified why the flake was happening and filed a bug, so I'm leaving the enabling as only chromeos and windows at this time. These tests were disabled because the resize lock can trigger at random points, blocking event delivery and breaking the tests. I've added a switch to disable the resize lock so that events now have known delivery order. BUG=331924, 640741 TEST=none R=oshima@chromium.org Committed: https://crrev.com/49530a1b55b7b3b6d1210d2dfdb6d8b075a1116d Cr-Commit-Position: refs/heads/master@{#414198}

Patch Set 1 #

Patch Set 2 : tweaks #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -3 lines) Patch
M chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc View 1 3 chunks +7 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
sky
4 years, 3 months ago (2016-08-24 21:14:43 UTC) #1
oshima
lgtm
4 years, 3 months ago (2016-08-24 22:19:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2277923002/20001
4 years, 3 months ago (2016-08-24 22:23:16 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-08-24 23:38:06 UTC) #8
commit-bot: I haz the power
4 years, 3 months ago (2016-08-24 23:39:54 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/49530a1b55b7b3b6d1210d2dfdb6d8b075a1116d
Cr-Commit-Position: refs/heads/master@{#414198}

Powered by Google App Engine
This is Rietveld 408576698