Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issue 2277903002: SkPngCodec: voidp instead of forward-declares for png.h types. (Closed)

Created:
4 years, 3 months ago by mtklein_C
Modified:
4 years, 3 months ago
Reviewers:
msarett
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

SkPngCodec: voidp instead of forward-declares for png.h types. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2277903002 Committed: https://skia.googlesource.com/skia/+/6dc5b9a9b79b9d71e772c47a4346fde31f3e7bfb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -13 lines) Patch
M src/codec/SkPngCodec.h View 3 chunks +17 lines, -10 lines 0 comments Download
M src/codec/SkPngCodec.cpp View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
mtklein_C
4 years, 3 months ago (2016-08-24 18:51:52 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2277903002/1
4 years, 3 months ago (2016-08-24 18:51:58 UTC) #5
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
4 years, 3 months ago (2016-08-24 18:51:59 UTC) #6
msarett
lgtm
4 years, 3 months ago (2016-08-24 18:53:44 UTC) #7
commit-bot: I haz the power
4 years, 3 months ago (2016-08-24 19:23:36 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/6dc5b9a9b79b9d71e772c47a4346fde31f3e7bfb

Powered by Google App Engine
This is Rietveld 408576698