Adds some tests for dart::bin::Directory.

runtime/bin/directory_test.cc

Index: runtime/bin/directory_test.cc
diff --git a/runtime/bin/directory_test.cc b/runtime/bin/directory_test.cc
new file mode 100644
index 0000000000000000000000000000000000000000..fa482ec1c3faa2c00960b1fad84a4568a39f7be1
--- /dev/null
+++ b/runtime/bin/directory_test.cc
@@ -0,0 +1,143 @@
+// Copyright (c) 2016, the Dart project authors.  Please see the AUTHORS file
+// for details. All rights reserved. Use of this source code is governed by a
+// BSD-style license that can be found in the LICENSE file.
+
+#include "bin/directory.h"
+#include "include/dart_api.h"
+#include "platform/assert.h"
+#include "vm/isolate.h"
+#include "vm/thread.h"
+#include "vm/unit_test.h"
+
+namespace dart {
+
+UNIT_TEST_CASE(DirectoryCurrentNoScope) {
+  char* current_dir = dart::bin::Directory::CurrentNoScope();
+  EXPECT_NOTNULL(current_dir);
+  free(current_dir);
+}
+
+
+UNIT_TEST_CASE(DirectoryExists) {
+  char* current_dir = dart::bin::Directory::CurrentNoScope();
+  EXPECT_NOTNULL(current_dir);
+
+  dart::bin::Directory::ExistsResult r =
+      dart::bin::Directory::Exists(current_dir);
+  EXPECT_EQ(dart::bin::Directory::EXISTS, r);
+
+  free(current_dir);
+}
+
+
+TEST_CASE(DirectoryCurrent) {
+  const char* current = dart::bin::Directory::Current();
+  EXPECT_NOTNULL(current);
+}
+
+
+TEST_CASE(DirectorySystemTemp) {
+  const char* system_temp = dart::bin::Directory::SystemTemp();
+  EXPECT_NOTNULL(system_temp);
+}
+
+
+TEST_CASE(DirectoryCreateTemp) {
+  const char* kTempPrefix = "test_prefix";
+  const char* system_temp = dart::bin::Directory::SystemTemp();
+  EXPECT_NOTNULL(system_temp);
+
+  const char* temp_dir = dart::bin::Directory::CreateTemp(kTempPrefix);
+  EXPECT_NOTNULL(temp_dir);
+
+  // Make sure temp_dir contains test_prefix.
+  EXPECT_NOTNULL(strstr(temp_dir, kTempPrefix));
+
+  // Cleanup.
+  dart::bin::Directory::Delete(temp_dir, false);

[siva, 2016/08/25 18:11:51]

is there a return code for this to ensure the delete was successful?

[zra, 2016/08/25 19:47:16]

Yes. Returns bool. Added EXPECT here and others.

+}
+
+
+TEST_CASE(DirectorySetCurrent) {
+  const char* current = dart::bin::Directory::Current();
+  EXPECT_NOTNULL(current);
+
+  const char* system_temp = dart::bin::Directory::SystemTemp();
+  EXPECT_NOTNULL(system_temp);
+
+  EXPECT(dart::bin::Directory::SetCurrent(system_temp));
+
+  const char* new_current = dart::bin::Directory::Current();
+  EXPECT_NOTNULL(new_current);
+
+  EXPECT_EQ(0, strcmp(system_temp, new_current));
+
+  EXPECT(dart::bin::Directory::SetCurrent(current));
+}
+
+
+TEST_CASE(DirectoryCreateDelete) {
+  const char* kTempDirName = "test_name";
+
+  const char* system_temp = dart::bin::Directory::SystemTemp();
+  EXPECT_NOTNULL(system_temp);
+
+  const intptr_t name_len =
+      snprintf(NULL, 0, "%s/%s", system_temp, kTempDirName);
+  ASSERT(name_len > 0);
+  char* name = new char[name_len + 1];
+  snprintf(name, name_len + 1, "%s/%s", system_temp, kTempDirName);
+
+  // Make a directory.
+  EXPECT(dart::bin::Directory::Create(name));
+
+  // Make sure it exists.
+  dart::bin::Directory::ExistsResult r = dart::bin::Directory::Exists(name);
+  EXPECT_EQ(dart::bin::Directory::EXISTS, r);
+
+  // Cleanup.
+  dart::bin::Directory::Delete(name, false);
+  delete[] name;
+}
+
+
+TEST_CASE(DirectoryRename) {
+  const char* kTempDirName = "test_name";
+
+  const char* system_temp = dart::bin::Directory::SystemTemp();
+  EXPECT_NOTNULL(system_temp);
+
+  const intptr_t name_len =
+      snprintf(NULL, 0, "%s/%s", system_temp, kTempDirName);
+  ASSERT(name_len > 0);
+  char* name = new char[name_len + 1];
+  snprintf(name, name_len + 1, "%s/%s", system_temp, kTempDirName);
+
+  // Make a directory.
+  EXPECT(dart::bin::Directory::Create(name));
+
+  // Make sure it exists.
+  dart::bin::Directory::ExistsResult r = dart::bin::Directory::Exists(name);
+  EXPECT_EQ(dart::bin::Directory::EXISTS, r);
+
+  const intptr_t new_name_len =
+      snprintf(NULL, 0, "%s/%snewname", system_temp, kTempDirName);
+  ASSERT(new_name_len > 0);
+  char* new_name = new char[new_name_len + 1];
+  snprintf(new_name, new_name_len + 1, "%s/%snewname",
+      system_temp, kTempDirName);
+
+  EXPECT(dart::bin::Directory::Rename(name, new_name));
+
+  r = dart::bin::Directory::Exists(new_name);
+  EXPECT_EQ(dart::bin::Directory::EXISTS, r);
+
+  r = dart::bin::Directory::Exists(name);
+  EXPECT_EQ(dart::bin::Directory::DOES_NOT_EXIST, r);
+
+  dart::bin::Directory::Delete(new_name, false);
+  delete[] name;
+  delete[] new_name;
+}
+
+}  // namespace dart