Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issue 2277883005: Adds some tests for dart::bin::Directory. (Closed)

Created:
4 years, 3 months ago by zra
Modified:
4 years, 3 months ago
Reviewers:
Cutch, siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Remove stray comment #

Total comments: 2

Patch Set 3 : Add EXPECT around Delete #

Unified diffs Side-by-side diffs Delta from patch set Stats (+144 lines, -0 lines) Patch
M runtime/bin/builtin_impl_sources.gypi View 1 chunk +1 line, -0 lines 0 comments Download
A runtime/bin/directory_test.cc View 1 2 1 chunk +143 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
zra
4 years, 3 months ago (2016-08-25 17:57:52 UTC) #2
siva
lgtm https://codereview.chromium.org/2277883005/diff/20001/runtime/bin/directory_test.cc File runtime/bin/directory_test.cc (right): https://codereview.chromium.org/2277883005/diff/20001/runtime/bin/directory_test.cc#newcode57 runtime/bin/directory_test.cc:57: dart::bin::Directory::Delete(temp_dir, false); is there a return code for ...
4 years, 3 months ago (2016-08-25 18:11:51 UTC) #3
zra
https://codereview.chromium.org/2277883005/diff/20001/runtime/bin/directory_test.cc File runtime/bin/directory_test.cc (right): https://codereview.chromium.org/2277883005/diff/20001/runtime/bin/directory_test.cc#newcode57 runtime/bin/directory_test.cc:57: dart::bin::Directory::Delete(temp_dir, false); On 2016/08/25 18:11:51, siva wrote: > is ...
4 years, 3 months ago (2016-08-25 19:47:16 UTC) #4
zra
4 years, 3 months ago (2016-08-25 19:47:45 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
720ebb4a9ccba47ab821d1be6e113a2207052a09 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698