Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1515)

Unified Diff: content/browser/renderer_host/delegated_frame_host.cc

Issue 2277883002: Use vsync manager regardless of begin frame settings (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Comments Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/delegated_frame_host.cc
diff --git a/content/browser/renderer_host/delegated_frame_host.cc b/content/browser/renderer_host/delegated_frame_host.cc
index 7b81ae4e6674c7b48495c25de2d4b18915ce70a8..c44707a50c6622748a5c728fd50fa7c11e89e0f6 100644
--- a/content/browser/renderer_host/delegated_frame_host.cc
+++ b/content/browser/renderer_host/delegated_frame_host.cc
@@ -13,6 +13,7 @@
#include "base/command_line.h"
#include "base/memory/ptr_util.h"
#include "base/time/default_tick_clock.h"
+#include "cc/base/switches.h"
#include "cc/output/compositor_frame.h"
#include "cc/output/copy_output_request.h"
#include "cc/resources/single_release_callback.h"
@@ -65,6 +66,9 @@ void RequireCallback(cc::SurfaceManager* manager,
DelegatedFrameHost::DelegatedFrameHost(DelegatedFrameHostClient* client)
: client_(client),
compositor_(nullptr),
+ using_begin_frame_scheduling_(
+ !base::CommandLine::ForCurrentProcess()->HasSwitch(
+ cc::switches::kDisableBeginFrameScheduling)),
tick_clock_(new base::DefaultTickClock()),
last_output_surface_id_(0),
pending_delegated_ack_count_(0),
@@ -797,8 +801,9 @@ void DelegatedFrameHost::OnCompositingShuttingDown(ui::Compositor* compositor) {
void DelegatedFrameHost::OnUpdateVSyncParameters(base::TimeTicks timebase,
base::TimeDelta interval) {
- SetVSyncParameters(timebase, interval);
- if (client_->DelegatedFrameHostIsVisible())
+ vsync_timebase_ = timebase;
+ vsync_interval_ = interval;
+ if (!using_begin_frame_scheduling_ && client_->DelegatedFrameHostIsVisible())
client_->DelegatedFrameHostUpdateVSyncParameters(timebase, interval);
}
@@ -854,21 +859,15 @@ void DelegatedFrameHost::ResetCompositor() {
}
if (compositor_->HasObserver(this))
compositor_->RemoveObserver(this);
- if (vsync_manager_.get()) {
+ if (vsync_manager_) {
vsync_manager_->RemoveObserver(this);
- vsync_manager_ = NULL;
+ vsync_manager_ = nullptr;
}
compositor_->RemoveSurfaceClient(id_allocator_->client_id());
compositor_ = nullptr;
}
-void DelegatedFrameHost::SetVSyncParameters(const base::TimeTicks& timebase,
- const base::TimeDelta& interval) {
- vsync_timebase_ = timebase;
- vsync_interval_ = interval;
-}
-
void DelegatedFrameHost::LockResources() {
DCHECK(!surface_id_.is_null());
delegated_frame_evictor_->LockFrame();

Powered by Google App Engine
This is Rietveld 408576698