Use vsync manager regardless of begin frame settings

ui/compositor/compositor.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/compositor/compositor.h"
 
 #include <stddef.h>
 
 #include <algorithm>
 #include <deque>
@@ skipping 380 matching lines @@
 }
 
 bool Compositor::GetScrollOffsetForLayer(int layer_id,
                                          gfx::ScrollOffset* offset) const {
   return host_->GetInputHandler()->GetScrollOffsetForLayer(layer_id, offset);
 }
 
 void Compositor::SetAuthoritativeVSyncInterval(
     const base::TimeDelta& interval) {
   context_factory_->SetAuthoritativeVSyncInterval(this, interval);
-  if (base::CommandLine::ForCurrentProcess()->HasSwitch(
-         cc::switches::kDisableBeginFrameScheduling)) {
-    vsync_manager_->SetAuthoritativeVSyncInterval(interval);
-  }
+  vsync_manager_->SetAuthoritativeVSyncInterval(interval);
+}
+
+void Compositor::SetDisplayVSyncParameters(base::TimeTicks timebase,
+                                           base::TimeDelta interval) {

[piman, 2016/08/24 21:23:58]

This is only called on mac, by BrowserCompositorMac::UpdateVSyncParameters,
right?
In particular, BrowserCompositorOutputSurface skips it and goes directly to the
BeginFrameSource and the VSyncManager.

There doesn't seem like there's a good way to make it more consistent, but it
would be nice to document this fact.

[enne (OOO), 2016/08/24 21:48:37]

Do you want more than the comment I added in compositor.h?

And yeah, I felt sad about adding this at the time, but I couldn't come up with
a better way to route this.  This isn't a great alternate route, but it's not
that terrible either.  One possibility is that I could go Compositor ->
GpuProcessTransportFactory -> Display -> BrowserCompositorOutputSurface if I
made Display use BrowserCompositorOutputSurface instead of just plain
OutputSurface, but I'm not sure if I like Display knowing that.

+  context_factory_->SetDisplayVSyncParameters(this, timebase, interval);
+  vsync_manager_->UpdateVSyncParameters(timebase, interval);
 }
 
 void Compositor::SetAcceleratedWidget(gfx::AcceleratedWidget widget) {
   // This function should only get called once.
   DCHECK(!widget_valid_);
   widget_ = widget;
   widget_valid_ = true;
   if (output_surface_requested_)
     context_factory_->CreateOutputSurface(weak_ptr_factory_.GetWeakPtr());
 }
@@ skipping 165 matching lines @@
                     observer_list_,
                     OnCompositingLockStateChanged(this));
 }
 
 void Compositor::CancelCompositorLock() {
   if (compositor_lock_)
     compositor_lock_->CancelLock();
 }
 
 }  // namespace ui