Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2311)

Unified Diff: base/native_library_mac.mm

Issue 2277863002: Enable loading native libraries with RTLD_DEEPBIND (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: \o/ Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/native_library_mac.mm
diff --git a/base/native_library_mac.mm b/base/native_library_mac.mm
index f2df0a711a436087c3ff15f99fa2406c3b9b8957..db770c6c374e8cf678d6f6f23bcdb58e60ba0e92 100644
--- a/base/native_library_mac.mm
+++ b/base/native_library_mac.mm
@@ -39,8 +39,9 @@ std::string NativeLibraryLoadError::ToString() const {
}
// static
-NativeLibrary LoadNativeLibrary(const FilePath& library_path,
- NativeLibraryLoadError* error) {
+NativeLibrary LoadNativeLibraryWithOptions(const FilePath& library_path,
+ const NativeLibraryOptions& options,
Lei Zhang 2016/08/25 23:08:58 Do we want to DCHECK() |options| and see if anyone
Ken Rockot(use gerrit already) 2016/08/25 23:20:42 Indeed, we went over this already :) To summarize:
+ NativeLibraryLoadError* error) {
// dlopen() etc. open the file off disk.
if (library_path.Extension() == "dylib" || !DirectoryExists(library_path)) {
void* dylib = dlopen(library_path.value().c_str(), RTLD_LAZY);

Powered by Google App Engine
This is Rietveld 408576698