Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Unified Diff: mojo/public/cpp/bindings/lib/validation_util.cc

Issue 2277853003: Use unions for interface control messages. (Closed)
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/public/cpp/bindings/lib/validation_util.cc
diff --git a/mojo/public/cpp/bindings/lib/validation_util.cc b/mojo/public/cpp/bindings/lib/validation_util.cc
index 4824477272e24d796d1c2303ea69a64b79de59ca..944c6541323bdb5aa36edc5268bd9d6bc19e10c0 100644
--- a/mojo/public/cpp/bindings/lib/validation_util.cc
+++ b/mojo/public/cpp/bindings/lib/validation_util.cc
@@ -103,16 +103,18 @@ bool ValidateMessageIsResponse(const Message* message,
bool ValidateControlRequest(const Message* message,
ValidationContext* validation_context) {
switch (message->header()->name) {
- case kRunMessageId:
+ case interface_control::kRunMessageId:
return ValidateMessageIsRequestExpectingResponse(message,
validation_context) &&
- ValidateMessagePayload<RunMessageParams_Data>(message,
- validation_context);
- case kRunOrClosePipeMessageId:
+ ValidateMessagePayload<
+ interface_control::internal::RunMessageParams_Data>(
+ message, validation_context);
+ case interface_control::kRunOrClosePipeMessageId:
return ValidateMessageIsRequestWithoutResponse(message,
validation_context) &&
- ValidateMessagePayload<RunOrClosePipeMessageParams_Data>(
- message, validation_context);
+ ValidateMessagePayload<
+ interface_control::internal::RunOrClosePipeMessageParams_Data>(
+ message, validation_context);
}
return false;
}
@@ -122,8 +124,9 @@ bool ValidateControlResponse(const Message* message,
if (!ValidateMessageIsResponse(message, validation_context))
return false;
switch (message->header()->name) {
- case kRunMessageId:
- return ValidateMessagePayload<RunResponseMessageParams_Data>(
+ case interface_control::kRunMessageId:
+ return ValidateMessagePayload<
+ interface_control::internal::RunResponseMessageParams_Data>(
message, validation_context);
}
return false;

Powered by Google App Engine
This is Rietveld 408576698