Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(300)

Unified Diff: mojo/public/java/bindings/src/org/chromium/mojo/bindings/Interface.java

Issue 2277853003: Use unions for interface control messages. (Closed)
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/public/java/bindings/src/org/chromium/mojo/bindings/Interface.java
diff --git a/mojo/public/java/bindings/src/org/chromium/mojo/bindings/Interface.java b/mojo/public/java/bindings/src/org/chromium/mojo/bindings/Interface.java
index c2bbc8ebddb4127bef1020b75395dd673b8ad691..a81bb1819047889db10b6a696e0fa4c6bfec0cf0 100644
--- a/mojo/public/java/bindings/src/org/chromium/mojo/bindings/Interface.java
+++ b/mojo/public/java/bindings/src/org/chromium/mojo/bindings/Interface.java
@@ -6,6 +6,14 @@ package org.chromium.mojo.bindings;
import org.chromium.mojo.bindings.Callbacks.Callback1;
import org.chromium.mojo.bindings.Interface.AbstractProxy.HandlerImpl;
+import org.chromium.mojo.bindings.interfacecontrol.QueryVersion;
+import org.chromium.mojo.bindings.interfacecontrol.RequireVersion;
+import org.chromium.mojo.bindings.interfacecontrol.RunInput;
+import org.chromium.mojo.bindings.interfacecontrol.RunMessageParams;
+import org.chromium.mojo.bindings.interfacecontrol.RunOrClosePipeInput;
+import org.chromium.mojo.bindings.interfacecontrol.RunOrClosePipeMessageParams;
+import org.chromium.mojo.bindings.interfacecontrol.RunOutput;
+import org.chromium.mojo.bindings.interfacecontrol.RunResponseMessageParams;
import org.chromium.mojo.system.Core;
import org.chromium.mojo.system.MessagePipeHandle;
import org.chromium.mojo.system.MojoException;
@@ -186,15 +194,18 @@ public interface Interface extends ConnectionErrorHandler, Closeable {
@Override
public void queryVersion(final Callback1<Integer> callback) {
RunMessageParams message = new RunMessageParams();
- message.reserved0 = 16;
- message.reserved1 = 0;
- message.queryVersion = new QueryVersion();
+ message.input = new RunInput();
+ message.input.setQueryVersion(new QueryVersion());
InterfaceControlMessagesHelper.sendRunMessage(getCore(), mMessageReceiver, message,
new Callback1<RunResponseMessageParams>() {
@Override
public void call(RunResponseMessageParams response) {
- mVersion = response.queryVersionResult.version;
+ if (response.output != null
+ && response.output.which()
+ == RunOutput.Tag.QueryVersionResult) {
+ mVersion = response.output.getQueryVersionResult().version;
+ }
callback.call(mVersion);
}
});
@@ -210,10 +221,9 @@ public interface Interface extends ConnectionErrorHandler, Closeable {
}
mVersion = version;
RunOrClosePipeMessageParams message = new RunOrClosePipeMessageParams();
- message.reserved0 = 16;
- message.reserved1 = 0;
- message.requireVersion = new RequireVersion();
- message.requireVersion.version = version;
+ message.input = new RunOrClosePipeInput();
+ message.input.setRequireVersion(new RequireVersion());
+ message.input.getRequireVersion().version = version;
InterfaceControlMessagesHelper.sendRunOrClosePipeMessage(
getCore(), mMessageReceiver, message);
}

Powered by Google App Engine
This is Rietveld 408576698