[Chromecast] Support blocking some video resolutions

[Chromecast] Support blocking some video resolutions

This allows playback to be blocked based on certain conditions
including video resolution (see linked bug + internal CL).

BUG=internal b/31055542

Committed: https://crrev.com/f5a81bb9091196d66394c85fecd281b2bb99aa60
Cr-Commit-Position: refs/heads/master@{#415218}

[halliwell, 2016-08-24 18:03:28]

Description was changed from

==========
[Chromecast] Support blocking some video resolutions

This allows playback to be blocked based on certain conditions
including video resolution (see linked bug + internal CL).

BUG=internal b/31055542
==========

to

==========
[Chromecast] Support blocking some video resolutions

This allows playback to be blocked based on certain conditions
including video resolution (see linked bug + internal CL).

BUG=internal b/31055542
==========

[halliwell, 2016-08-24 18:03:28]

halliwell@chromium.org changed reviewers:
+ alokp@chromium.org, servolk@chromium.org

[alokp, 2016-08-24 18:09:39]

High-level question: Can't this be handled by media-caps canPlayType?

[halliwell, 2016-08-24 18:11:28]

On 2016/08/24 18:09:39, alokp wrote:
> High-level question: Can't this be handled by media-caps canPlayType?

Well ... yes and no.  Please read the bug.  canPlayType is the primary
mechanism; this is a backup.

[halliwell, 2016-08-26 14:36:46]

On 2016/08/24 18:11:28, halliwell wrote:
> On 2016/08/24 18:09:39, alokp wrote:
> > High-level question: Can't this be handled by media-caps canPlayType?
> 
> Well ... yes and no.  Please read the bug.  canPlayType is the primary
> mechanism; this is a backup.

PTAL.  I added a TODO about when we can remove this.

[servolk, 2016-08-26 22:08:57]

On 2016/08/26 14:36:46, halliwell wrote:
> On 2016/08/24 18:11:28, halliwell wrote:
> > On 2016/08/24 18:09:39, alokp wrote:
> > > High-level question: Can't this be handled by media-caps canPlayType?
> > 
> > Well ... yes and no.  Please read the bug.  canPlayType is the primary
> > mechanism; this is a backup.
> 
> PTAL.  I added a TODO about when we can remove this.

lgtm % nit. also, as I've explained in the internal CL ideally I'd prefer to
have this done in Marvell/vendor code. But that's not an easy option atm.

[halliwell, 2016-08-26 22:33:53]

On 2016/08/26 22:08:57, servolk wrote:
> On 2016/08/26 14:36:46, halliwell wrote:
> > On 2016/08/24 18:11:28, halliwell wrote:
> > > On 2016/08/24 18:09:39, alokp wrote:
> > > > High-level question: Can't this be handled by media-caps canPlayType?
> > > 
> > > Well ... yes and no.  Please read the bug.  canPlayType is the primary
> > > mechanism; this is a backup.
> > 
> > PTAL.  I added a TODO about when we can remove this.
> 
> lgtm % nit. also, as I've explained in the internal CL ideally I'd prefer to
> have this done in Marvell/vendor code. But that's not an easy option atm.

Did you forget to post the nit? :)

[servolk, 2016-08-26 22:36:22]

https://codereview.chromium.org/2277853002/diff/20001/chromecast/browser/medi...
File chromecast/browser/media/video_resolution_policy.h (right):

https://codereview.chromium.org/2277853002/diff/20001/chromecast/browser/medi...
chromecast/browser/media/video_resolution_policy.h:19: // TODO(halliwell):
remove this mechanism once we have PR3.
Nit: if there's a tracking bug for this, let's mention it here.

[servolk, 2016-08-26 22:36:39]

On 2016/08/26 22:33:53, halliwell wrote:
> On 2016/08/26 22:08:57, servolk wrote:
> > On 2016/08/26 14:36:46, halliwell wrote:
> > > On 2016/08/24 18:11:28, halliwell wrote:
> > > > On 2016/08/24 18:09:39, alokp wrote:
> > > > > High-level question: Can't this be handled by media-caps canPlayType?
> > > > 
> > > > Well ... yes and no.  Please read the bug.  canPlayType is the primary
> > > > mechanism; this is a backup.
> > > 
> > > PTAL.  I added a TODO about when we can remove this.
> > 
> > lgtm % nit. also, as I've explained in the internal CL ideally I'd prefer to
> > have this done in Marvell/vendor code. But that's not an easy option atm.
> 
> Did you forget to post the nit? :)

ah, yes, sorry

[alokp, 2016-08-26 22:49:38]

lgtm

[halliwell, 2016-08-29 15:23:50]

The CQ bit was checked by halliwell@chromium.org

[commit-bot: I haz the power, 2016-08-29 15:24:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dsansome, 2016-08-30 01:45:58]

The CQ bit was unchecked by dsansome@chromium.org

[dsansome, 2016-08-30 03:54:23]

dsansome@chromium.org changed reviewers:
+ dsansome@chromium.org

[dsansome, 2016-08-30 03:54:23]

(I unset the commit bit on this change to try fix a stuck CQ -
https://bugs.chromium.org/p/chromium/issues/detail?id=642077.  The issue is
fixed now so I'm sending this to CQ again for you)

[dsansome, 2016-08-30 03:54:55]

The CQ bit was checked by dsansome@chromium.org

[commit-bot: I haz the power, 2016-08-30 03:57:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-30 06:24:17]

Description was changed from

==========
[Chromecast] Support blocking some video resolutions

This allows playback to be blocked based on certain conditions
including video resolution (see linked bug + internal CL).

BUG=internal b/31055542
==========

to

==========
[Chromecast] Support blocking some video resolutions

This allows playback to be blocked based on certain conditions
including video resolution (see linked bug + internal CL).

BUG=internal b/31055542
==========

[commit-bot: I haz the power, 2016-08-30 06:24:18]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-30 06:26:48]

Description was changed from

==========
[Chromecast] Support blocking some video resolutions

This allows playback to be blocked based on certain conditions
including video resolution (see linked bug + internal CL).

BUG=internal b/31055542
==========

to

==========
[Chromecast] Support blocking some video resolutions

This allows playback to be blocked based on certain conditions
including video resolution (see linked bug + internal CL).

BUG=internal b/31055542

Committed: https://crrev.com/f5a81bb9091196d66394c85fecd281b2bb99aa60
Cr-Commit-Position: refs/heads/master@{#415218}
==========

[commit-bot: I haz the power, 2016-08-30 06:26:50]

Patchset 2 (id:??) landed as
https://crrev.com/f5a81bb9091196d66394c85fecd281b2bb99aa60
Cr-Commit-Position: refs/heads/master@{#415218}