Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(347)

Issue 2277833004: exo: Avoid creating transparent texture quads. (Closed)

Created:
4 years, 4 months ago by reveman
Modified:
4 years, 4 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

exo: Avoid creating transparent texture quads. The surface is fully transparent when alpha is 0 and we can then avoid to create a texture quad completely. Failing to do so currently results in unnecessary compositing. BUG=640805 TEST=exo_unittests Committed: https://crrev.com/e2d54b85fbc32bd0d19e1741677a296e25fd47c7 Cr-Commit-Position: refs/heads/master@{#414220}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -17 lines) Patch
M components/exo/surface.cc View 1 chunk +20 lines, -17 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
reveman
4 years, 4 months ago (2016-08-24 23:34:14 UTC) #2
jbauman
lgtm
4 years, 4 months ago (2016-08-24 23:37:01 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2277833004/1
4 years, 4 months ago (2016-08-24 23:40:23 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-25 00:30:54 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-08-25 00:33:48 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e2d54b85fbc32bd0d19e1741677a296e25fd47c7
Cr-Commit-Position: refs/heads/master@{#414220}

Powered by Google App Engine
This is Rietveld 408576698