Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 2277833003: Turn Message Center Menus Async (Closed)

Created:
4 years, 4 months ago by jonross
Modified:
4 years, 3 months ago
Reviewers:
dewittj
CC:
chromium-reviews, Peter Beverloo, mlamouri+watch-notifications_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Turn Message Center Menus Async Turn the context menu, and the notification settings menu, to use the ASYNC runtype TEST=manual testing of the menus, message_center_unittests BUG=557136 Committed: https://crrev.com/8bbaf67cd3ac821e9389dd3c9f02f74980b17eac Cr-Commit-Position: refs/heads/master@{#415433}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -18 lines) Patch
M ui/message_center/views/message_view_context_menu_controller.h View 2 chunks +18 lines, -0 lines 0 comments Download
M ui/message_center/views/message_view_context_menu_controller.cc View 2 chunks +21 lines, -10 lines 0 comments Download
M ui/message_center/views/notifier_settings_view.h View 3 chunks +5 lines, -0 lines 0 comments Download
M ui/message_center/views/notifier_settings_view.cc View 2 chunks +17 lines, -8 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
jonross
Hi dewittj@, I'm working on transitioning menus from the current nested message loop, to a ...
4 years, 3 months ago (2016-08-25 13:19:59 UTC) #6
jonross
On 2016/08/25 13:19:59, jonross wrote: > Hi dewittj@, > > I'm working on transitioning menus ...
4 years, 3 months ago (2016-08-30 15:04:04 UTC) #7
dewittj
lgtm
4 years, 3 months ago (2016-08-30 19:43:49 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2277833003/1
4 years, 3 months ago (2016-08-30 20:39:30 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-30 21:30:52 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-08-30 21:32:59 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8bbaf67cd3ac821e9389dd3c9f02f74980b17eac
Cr-Commit-Position: refs/heads/master@{#415433}

Powered by Google App Engine
This is Rietveld 408576698