Issue 2277833002: Properly reenable focus change animations when aborting a page load on the NTP.

Issue 2277833002: Properly reenable focus change animations when aborting a page load on the NTP. (Closed)

Created:
4 years, 3 months ago by Bernhard Bauer

Modified:
4 years, 3 months ago

Reviewers:
Ted C, mdjones

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Properly reenable focus change animations when aborting a page load on the NTP. BUG=640560 Committed: https://crrev.com/2fad80e5e57311e738a1f2d9624de390d602e0cf Cr-Commit-Position: refs/heads/master@{#414377}

Created: 4 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -6 lines)			Patch
	M	chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarManager.java	View		3 chunks	+16 lines, -6 lines	0 comments	Download

Total messages: 10 (4 generated)

Ted C

lgtm but I'd like mdjones@ to take a quick peek since he modified this in: ...

4 years, 3 months ago (2016-08-24 17:29:15 UTC) #4

mdjones

lgtm; it's a bit upsetting that we can trigger a navigation from the ntp to ...

4 years, 3 months ago (2016-08-24 22:22:03 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2277833002/1

4 years, 3 months ago (2016-08-25 09:02:32 UTC) #7

commit-bot: I haz the power

4 years, 3 months ago (2016-08-25 09:55:18 UTC) #10

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/2fad80e5e57311e738a1f2d9624de390d602e0cf
Cr-Commit-Position: refs/heads/master@{#414377}