Logging for RestartJob.

chromeos/dbus/session_manager_client.cc

Index: chromeos/dbus/session_manager_client.cc
diff --git a/chromeos/dbus/session_manager_client.cc b/chromeos/dbus/session_manager_client.cc
index 8b99b6965126ec0a0101e8f5a25e786668c510d3..012f3c9f8499b6200ec3adbfa05688c0f3996c99 100644
--- a/chromeos/dbus/session_manager_client.cc
+++ b/chromeos/dbus/session_manager_client.cc
@@ -83,6 +83,10 @@ void CreateValidCredConduit(dbus::FileDescriptor* local_auth_fd,
   remote_auth_fd->CheckValidity();
 }
 
+void HandleDBusError(dbus::ErrorResponse* response) {
+  PLOG(ERROR) << "DBus error " << response->ToString();

[Daniel Erat, 2016/08/25 02:13:19]

LOG(ERROR) is the right thing to use here. PLOG is only appropriate when a posix
call (read(), write(), fork(), exec(), etc.) failed immediately before and you
want to include the reason why. you don't know what the d-bus library called
immediately prior to handing you the error (and in this particular case, it
probably did a successful read() of the error message from a socket or something
similar to that, so PLOG would actually log "Success").

[achuithb, 2016/08/25 21:10:02]

Done.

Thanks for the explanation.

+}
+
 }  // namespace
 
 // The SessionManagerClient implementation used in production.
@@ -498,6 +502,7 @@ class SessionManagerClientImpl : public SessionManagerClient {
   void CallRestartJobWithValidFd(dbus::ScopedFileDescriptor local_auth_fd,
                                  dbus::ScopedFileDescriptor remote_auth_fd,
                                  const std::vector<std::string>& argv) {
+    VLOG(1) << "CallRestartJobWithValidFd";
     dbus::MethodCall method_call(login_manager::kSessionManagerInterface,
                                  login_manager::kSessionManagerRestartJob);
     dbus::MessageWriter writer(&method_call);
@@ -507,11 +512,12 @@ class SessionManagerClientImpl : public SessionManagerClient {
     // Ownership of local_auth_fd is passed to the callback that is to be
     // called on completion of this method call. This keeps the browser end
     // of the socket-pair alive for the duration of the RPC.
-    session_manager_proxy_->CallMethod(
+    session_manager_proxy_->CallMethodWithErrorCallback(
         &method_call, dbus::ObjectProxy::TIMEOUT_USE_DEFAULT,
         base::Bind(&SessionManagerClientImpl::OnRestartJob,
                    weak_ptr_factory_.GetWeakPtr(),
-                   base::Passed(&local_auth_fd)));
+                   base::Passed(&local_auth_fd)),
+        base::Bind(HandleDBusError));
   }
 
   // Called when kSessionManagerRestartJob method is complete.