build/config/compiler/BUILD.gn - Issue 2277783002: Revert of Make __DATE__ and __TIME__ to evaluate to an empty string.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/config/compiler/BUILD.gn

Issue 2277783002: Revert of Make __DATE__ and __TIME__ to evaluate to an empty string. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/config/compiler/BUILD.gn

diff --git a/build/config/compiler/BUILD.gn b/build/config/compiler/BUILD.gn

index 5680beba57f042cb5f1422a80f95bb12f1dcf2d5..5e6d53095474bd9dcaaedf8b2d818170ffb79ed7 100644

--- a/build/config/compiler/BUILD.gn

+++ b/build/config/compiler/BUILD.gn

@@ -166,15 +166,6 @@

# Common GCC compiler flags setup.

# --------------------------------

cflags += [ "-fno-strict-aliasing" ] # See http://crbug.com/32204

- # Eliminate build metadata (__DATE__ and __TIME_) for deterministic build.

- # See https://crbug.com/314403

- cflags += [

- "-Wno-builtin-macro-redefined",

- "-D__DATE__=",

- "-D__TIME__=",

- ]

cflags_cc += [

# If this is removed then remove the corresponding /Zc:threadSafeInit- for

# Windows.

« no previous file with comments | « no previous file | no next file » | no next file with comments »