Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1077)

Issue 2277783002: Revert of Make __DATE__ and __TIME__ to evaluate to an empty string. (Closed)

Created:
4 years, 4 months ago by justincohen
Modified:
4 years, 4 months ago
CC:
chromium-reviews, Nico
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Make __DATE__ and __TIME__ to evaluate to an empty string. (patchset #5 id:80001 of https://codereview.chromium.org/2255093004/ ) Reason for revert: This introduces a clang crash when pch are used. See: https://llvm.org/bugs/show_bug.cgi?id=29119 Original issue's description: > Make __DATE__ and __TIME__ to evaluate to an empty string. > > If __DATE__ or __TIME__ used in code, current date or time will be > filled. Such a value may change compile by compile, and breaks > deterministic build. > > BUG=314403 > > Committed: https://crrev.com/43088a9ef885a695061a49bcd0992cbce00a7568 > Cr-Commit-Position: refs/heads/master@{#414018} TBR=maruel@chromium.org,dpranke@google.com,dpranke@chromium.org,rohitrao@chromium.org,thakis@chromium.org,yyanagisawa@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=314403 NOTRY=TRUE Committed: https://crrev.com/3732ccadd4239a580746978396b8c69e9901f146 Cr-Commit-Position: refs/heads/master@{#414120}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -9 lines) Patch
M build/config/compiler/BUILD.gn View 1 chunk +0 lines, -9 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
justincohen
Created Revert of Make __DATE__ and __TIME__ to evaluate to an empty string.
4 years, 4 months ago (2016-08-24 15:44:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2277783002/1
4 years, 4 months ago (2016-08-24 15:44:29 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/128967)
4 years, 4 months ago (2016-08-24 18:28:45 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2277783002/1
4 years, 4 months ago (2016-08-24 19:26:53 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-08-24 19:33:24 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3732ccadd4239a580746978396b8c69e9901f146
Cr-Commit-Position: refs/heads/master@{#414120}

Powered by Google App Engine
This is Rietveld 408576698