Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(723)

Issue 2277753005: Import "NoInline" into core so StackTrace's use of it resolves. (Closed)

Created:
4 years, 3 months ago by Bob Nystrom
Modified:
4 years, 3 months ago
Reviewers:
vsm
CC:
dev-compiler+reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Import "NoInline" into core so StackTrace's use of it resolves. R=vsm@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/a651dfa794abd7a6faa5709f77ef48553ab6d8ef

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
A lib/runtime/dart_sdk.sum View Binary file 0 comments Download
M tool/input_sdk/lib/core/core.dart View 1 chunk +1 line, -0 lines 0 comments Download
M tool/sdk_expected_errors.txt View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Bob Nystrom
4 years, 3 months ago (2016-08-25 23:07:20 UTC) #2
vsm
lgtm
4 years, 3 months ago (2016-08-25 23:38:14 UTC) #3
Bob Nystrom
4 years, 3 months ago (2016-08-26 00:08:57 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a651dfa794abd7a6faa5709f77ef48553ab6d8ef (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698