Chromium Code Reviews

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/infobar/PermissionInfoBar.java

Issue 2277733002: Revert of Enable the optional permission prompt persistence toggle on grouped infobars (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@permission-infobardelegate-clean
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Index: chrome/android/java/src/org/chromium/chrome/browser/infobar/PermissionInfoBar.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/infobar/PermissionInfoBar.java b/chrome/android/java/src/org/chromium/chrome/browser/infobar/PermissionInfoBar.java
index 3c07ef1fe7f55e2d3e2d99a19979d04d1ec09ba9..993ec94586e01a9ddd8c29a7e1e47f801d590474 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/infobar/PermissionInfoBar.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/infobar/PermissionInfoBar.java
@@ -41,11 +41,10 @@
private SparseArray<String> mContentSettingsToPermissionsMap;
protected PermissionInfoBar(int iconDrawableId, Bitmap iconBitmap, String message,
- String linkText, String primaryButtonText, String secondaryButtonText,
- boolean showPersistenceToggle) {
+ String linkText, String primaryButtonText, String secondaryButtonText) {
super(iconDrawableId, iconBitmap, message, linkText, primaryButtonText,
secondaryButtonText);
- mShowPersistenceToggle = showPersistenceToggle;
+ mShowPersistenceToggle = false;
}
@Override
@@ -76,6 +75,16 @@
: "A WindowAndroid must be specified to request access to content settings";
mContentSettingsToPermissionsMap = generatePermissionsMapping(contentSettings);
+ }
+
+ /**
+ * Specifies whether or not this infobar should display a toggle asking the user if they want to
+ * save their choice.
+ *
+ * @param showPersistenceToggle True if the toggle should be displayed.
+ */
+ private void setShowPersistenceToggle(boolean showPersistenceToggle) {
+ mShowPersistenceToggle = showPersistenceToggle;
}
private SparseArray<String> generatePermissionsMapping(int[] contentSettings) {
@@ -195,7 +204,7 @@
* Returns true if the persist switch exists and is toggled on.
*/
@CalledByNative
- protected boolean isPersistSwitchOn() {
+ private boolean isPersistSwitchOn() {
SwitchCompat persistSwitch = (SwitchCompat) getView().findViewById(
R.id.permission_infobar_persist_toggle);
if (mShowPersistenceToggle && persistSwitch != null) {
@@ -227,8 +236,9 @@
int drawableId = ResourceId.mapToDrawableId(enumeratedIconId);
PermissionInfoBar infoBar = new PermissionInfoBar(drawableId, iconBitmap, message, linkText,
- buttonOk, buttonCancel, showPersistenceToggle);
+ buttonOk, buttonCancel);
infoBar.setContentSettings(windowAndroid, contentSettings);
+ infoBar.setShowPersistenceToggle(showPersistenceToggle);
return infoBar;
}

Powered by Google App Engine