[Remoting Android] Fix OAuthTokenConsumer's thread safety issue

[Remoting Android] Fix OAuthTokenConsumer's thread safety issue

OAuthTokenConsumer.revokeLatestToken() revokes the token on the background
thread and calls the callback directly on that thread once it is done. This
would be potentially thread unsafe if the caller doesn't realize the callback
will be called on a non-main thread. Currently we don't see any bug related
to this problem since the only caller of revokeLatestToken() passes in null
as the callback.

This CL makes revokeLatestToken() post a task to the main thread to run the
callback when the token is revoked.

Committed: https://crrev.com/e8f9faf5a2ace617a7ce1d775c96ead0df0a76d4
Cr-Commit-Position: refs/heads/master@{#414268}

[Yuwei, 2016-08-24 22:52:57]

yuweih@chromium.org changed reviewers:
+ lambroslambrou@chromium.org

[Yuwei, 2016-08-24 22:52:57]

ptal

[Yuwei, 2016-08-24 23:12:33]

Description was changed from

==========
[Remoting Android] Fix OAuthTokenConsumer's thread safety issue

OAuthTokenConsumer.revokeLatestToken() revokes the token on a separate thread
and calls the callback directly on that thread once it is done. This would be
potentially thread unsafe if the caller doesn't realize the callback will be
called on an anonymous thread. Currently we don't see any bug related to this
problem since the only caller of revokeLatestToken() passes in null as the
callback.

This CL makes revokeLatestToken() post a task to the main thread to run the
callback when the token is revoked.
==========

to

==========
[Remoting Android] Fix OAuthTokenConsumer's thread safety issue

OAuthTokenConsumer.revokeLatestToken() revokes the token on the background
thread and calls the callback directly on that thread once it is done. This
would be potentially thread unsafe if the caller doesn't realize the callback
will be called on a non-main thread. Currently we don't see any bug related
to this problem since the only caller of revokeLatestToken() passes in null
as the callback.

This CL makes revokeLatestToken() post a task to the main thread to run the
callback when the token is revoked.
==========

[Lambros, 2016-08-24 23:18:23]

lgtm

[Yuwei, 2016-08-24 23:19:48]

The CQ bit was checked by yuweih@chromium.org

[commit-bot: I haz the power, 2016-08-24 23:20:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-25 02:27:16]

Description was changed from

==========
[Remoting Android] Fix OAuthTokenConsumer's thread safety issue

OAuthTokenConsumer.revokeLatestToken() revokes the token on the background
thread and calls the callback directly on that thread once it is done. This
would be potentially thread unsafe if the caller doesn't realize the callback
will be called on a non-main thread. Currently we don't see any bug related
to this problem since the only caller of revokeLatestToken() passes in null
as the callback.

This CL makes revokeLatestToken() post a task to the main thread to run the
callback when the token is revoked.
==========

to

==========
[Remoting Android] Fix OAuthTokenConsumer's thread safety issue

OAuthTokenConsumer.revokeLatestToken() revokes the token on the background
thread and calls the callback directly on that thread once it is done. This
would be potentially thread unsafe if the caller doesn't realize the callback
will be called on a non-main thread. Currently we don't see any bug related
to this problem since the only caller of revokeLatestToken() passes in null
as the callback.

This CL makes revokeLatestToken() post a task to the main thread to run the
callback when the token is revoked.
==========

[commit-bot: I haz the power, 2016-08-25 02:27:16]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-08-25 02:30:36]

Description was changed from

==========
[Remoting Android] Fix OAuthTokenConsumer's thread safety issue

OAuthTokenConsumer.revokeLatestToken() revokes the token on the background
thread and calls the callback directly on that thread once it is done. This
would be potentially thread unsafe if the caller doesn't realize the callback
will be called on a non-main thread. Currently we don't see any bug related
to this problem since the only caller of revokeLatestToken() passes in null
as the callback.

This CL makes revokeLatestToken() post a task to the main thread to run the
callback when the token is revoked.
==========

to

==========
[Remoting Android] Fix OAuthTokenConsumer's thread safety issue

OAuthTokenConsumer.revokeLatestToken() revokes the token on the background
thread and calls the callback directly on that thread once it is done. This
would be potentially thread unsafe if the caller doesn't realize the callback
will be called on a non-main thread. Currently we don't see any bug related
to this problem since the only caller of revokeLatestToken() passes in null
as the callback.

This CL makes revokeLatestToken() post a task to the main thread to run the
callback when the token is revoked.

Committed: https://crrev.com/e8f9faf5a2ace617a7ce1d775c96ead0df0a76d4
Cr-Commit-Position: refs/heads/master@{#414268}
==========

[commit-bot: I haz the power, 2016-08-25 02:30:36]

Patchset 1 (id:??) landed as
https://crrev.com/e8f9faf5a2ace617a7ce1d775c96ead0df0a76d4
Cr-Commit-Position: refs/heads/master@{#414268}