Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(511)

Issue 2277703002: Revert of Streams: Remove isTerminating() calls (Closed)

Created:
4 years, 4 months ago by nhiroki
Modified:
4 years, 4 months ago
Reviewers:
haraken, yhirano
CC:
chromium-reviews, falken, kinuko+worker_chromium.org, blink-reviews-bindings_chromium.org, blink-reviews, horo+watch_chromium.org, blink-worker-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Streams: Remove isTerminating() calls (patchset #3 id:40001 of https://codereview.chromium.org/2265863002/ ) Reason for revert: This causes crashes (see https://bugs.chromium.org/p/chromium/issues/detail?id=640521) Original issue's description: > Streams: Remove isTerminating() calls > > isTerminating() is used for making sure whether a worker execution context is > still valid after V8 API calls, but this is no longer necessary thanks to > graceful shutdown mechanism for WorkerThread (https://crbug.com/487050) > > BUG=614272, 638877 > > Committed: https://crrev.com/53752ac68bbd8b93650a9475c9b5b5f2e13a8e9a > Cr-Commit-Position: refs/heads/master@{#413420} TBR=yhirano@chromium.org,haraken@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=614272, 638877 Committed: https://crrev.com/360cedf2865c54108fa97f246737454ff68fc9ad Cr-Commit-Position: refs/heads/master@{#414062}

Patch Set 1 #

Messages

Total messages: 7 (2 generated)
nhiroki
Created Revert of Streams: Remove isTerminating() calls
4 years, 4 months ago (2016-08-24 11:16:22 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2277703002/1
4 years, 4 months ago (2016-08-24 11:16:41 UTC) #3
haraken
LGTM
4 years, 4 months ago (2016-08-24 11:16:53 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-24 13:31:25 UTC) #5
commit-bot: I haz the power
4 years, 4 months ago (2016-08-24 13:33:00 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/360cedf2865c54108fa97f246737454ff68fc9ad
Cr-Commit-Position: refs/heads/master@{#414062}

Powered by Google App Engine
This is Rietveld 408576698