Issue 22777002: [NaCl SDK] Fix running .pexe in Release mode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 22777002: [NaCl SDK] Fix running .pexe in Release mode. (Closed)

Created:
7 years, 4 months ago by binji

Modified:
7 years, 4 months ago

Reviewers:
noelallen1

CC:
chromium-reviews, Sam Clegg

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[NaCl SDK] Fix running .pexe in Release mode. (NOTE: this fixes the NaCl SDK waterfall) A bug in common.js was causing the embed to load .pexe with application/x-nacl, which produces a bizarre failure message: NaCl module load failed: manifest: program property 'portable' does not have required key: 'url'. BUG=none R=noelallen@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=216889

Patch Set 1 #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -4 lines)			Patch
	M	native_client_sdk/src/examples/common.js	View		3 chunks	+7 lines, -4 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed patchset #1 manually as r216889.

Expand Messages | Collapse Messages