Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Issue 2277693002: Unflake link-crossorigin-stylesheet-no-cors.html (Closed)

Created:
4 years, 4 months ago by tyoshino (SeeGerritForStatus)
Modified:
4 years, 3 months ago
Reviewers:
yhirano
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Unflake link-crossorigin-stylesheet-no-cors.html The order of the CORS error messages for the link elements is not stable. Stop logging them and compare only output from the test cases. R=yhirano BUG=633834 Committed: https://crrev.com/f149409d2763e3cfb83b97549b2783ba299255a0 Cr-Commit-Position: refs/heads/master@{#415243}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed #7 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -6 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/security/link-crossorigin-stylesheet-no-cors.html View 1 1 chunk +10 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/security/link-crossorigin-stylesheet-no-cors-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 17 (9 generated)
tyoshino (SeeGerritForStatus)
4 years, 4 months ago (2016-08-24 10:51:43 UTC) #2
tyoshino (SeeGerritForStatus)
4 years, 3 months ago (2016-08-30 04:27:00 UTC) #6
yhirano
https://codereview.chromium.org/2277693002/diff/1/third_party/WebKit/LayoutTests/http/tests/security/link-crossorigin-stylesheet-no-cors.html File third_party/WebKit/LayoutTests/http/tests/security/link-crossorigin-stylesheet-no-cors.html (right): https://codereview.chromium.org/2277693002/diff/1/third_party/WebKit/LayoutTests/http/tests/security/link-crossorigin-stylesheet-no-cors.html#newcode11 third_party/WebKit/LayoutTests/http/tests/security/link-crossorigin-stylesheet-no-cors.html:11: if (testRunner) { window.testRunner When testRunner is not defined ...
4 years, 3 months ago (2016-08-30 04:34:17 UTC) #7
tyoshino (SeeGerritForStatus)
https://codereview.chromium.org/2277693002/diff/1/third_party/WebKit/LayoutTests/http/tests/security/link-crossorigin-stylesheet-no-cors.html File third_party/WebKit/LayoutTests/http/tests/security/link-crossorigin-stylesheet-no-cors.html (right): https://codereview.chromium.org/2277693002/diff/1/third_party/WebKit/LayoutTests/http/tests/security/link-crossorigin-stylesheet-no-cors.html#newcode11 third_party/WebKit/LayoutTests/http/tests/security/link-crossorigin-stylesheet-no-cors.html:11: if (testRunner) { On 2016/08/30 04:34:17, yhirano wrote: > ...
4 years, 3 months ago (2016-08-30 05:19:35 UTC) #8
yhirano
lgtm
4 years, 3 months ago (2016-08-30 05:38:16 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2277693002/20001
4 years, 3 months ago (2016-08-30 05:42:43 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-08-30 08:24:05 UTC) #15
commit-bot: I haz the power
4 years, 3 months ago (2016-08-30 08:26:15 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f149409d2763e3cfb83b97549b2783ba299255a0
Cr-Commit-Position: refs/heads/master@{#415243}

Powered by Google App Engine
This is Rietveld 408576698