Convert editing/execCommand/format-block-multiple-paragraphs-in-pre.html to use w3c test harness

Convert editing/execCommand/format-block-multiple-paragraphs-in-pre.html to use w3c test harness

This patch converts "editing/execCommand/format-block-multiple-paragraphs-in-pre.html"
to use w3c test harness to simplify test script for improving readability.

BUG=n/a
TEST=n/a; no behavior changes

Committed: https://crrev.com/2c1178c2b9f661399c61234b88375ec72320dadf
Cr-Commit-Position: refs/heads/master@{#414339}

[yosin_UTC9, 2016-08-24 08:36:12]

Description was changed from

==========
2016-08-24T17:34:54

BUG=
==========

to

==========
Convert editing/execCommand/crash-indenting-list-item to use w3c test harness

This patch converts "editing/execCommand/crash-indenting-list-item.html" to use
w3c test harness to simplify test script for improving readability.

Get rid of FrameSelection::moveTo() taking two VisiblePosition objects

This patch gets rid of |FrameSelection::moveTo()| taking two |VisiblePosition|
objects since its call site is only one for improving code health.

BUG=n/a
TEST=n/a; no behavior changes


Convert editing/execCommand/format-block-multiple-paragraphs-in-pre.html to use
w3c test harness

This patch converts
"editing/execCommand/format-block-multiple-paragraphs-in-pre.html"
to use w3c test harness to simplify test script for improving readability.

BUG=n/a
TEST=n/a; no behavior changes
==========

[yosin_UTC9, 2016-08-24 08:36:17]

The CQ bit was checked by yosin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-24 08:36:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yosin_UTC9, 2016-08-24 08:55:19]

Description was changed from

==========
Convert editing/execCommand/crash-indenting-list-item to use w3c test harness

This patch converts "editing/execCommand/crash-indenting-list-item.html" to use
w3c test harness to simplify test script for improving readability.

Get rid of FrameSelection::moveTo() taking two VisiblePosition objects

This patch gets rid of |FrameSelection::moveTo()| taking two |VisiblePosition|
objects since its call site is only one for improving code health.

BUG=n/a
TEST=n/a; no behavior changes


Convert editing/execCommand/format-block-multiple-paragraphs-in-pre.html to use
w3c test harness

This patch converts
"editing/execCommand/format-block-multiple-paragraphs-in-pre.html"
to use w3c test harness to simplify test script for improving readability.

BUG=n/a
TEST=n/a; no behavior changes
==========

to

==========
Convert editing/execCommand/crash-indenting-list-item to use w3c test harness

This patch converts "editing/execCommand/crash-indenting-list-item.html" to use
w3c test harness to simplify test script for improving readability.

BUG=n/a
TEST=n/a; no behavior changes
==========

[yosin_UTC9, 2016-08-24 08:56:45]

Description was changed from

==========
Convert editing/execCommand/crash-indenting-list-item to use w3c test harness

This patch converts "editing/execCommand/crash-indenting-list-item.html" to use
w3c test harness to simplify test script for improving readability.

BUG=n/a
TEST=n/a; no behavior changes
==========

to

==========
Convert editing/execCommand/crash-indenting-list-item.html to use w3c test
harness

This patch converts "editing/execCommand/crash-indenting-list-item.html" to use
w3c test harness to simplify test script for improving readability.

BUG=n/a
TEST=n/a; no behavior changes
==========

[yosin_UTC9, 2016-08-24 09:32:53]

yosin@chromium.org changed reviewers:
+ xiaochengh@chromium.org, yoichio@chromium.org

[yosin_UTC9, 2016-08-24 09:32:53]

PTAL

[commit-bot: I haz the power, 2016-08-24 10:16:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-24 10:16:31]

Dry run: This issue passed the CQ dry run.

[Xiaocheng, 2016-08-25 01:48:39]

The second and third tests do not match the original ones.

https://codereview.chromium.org/2277673002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/editing/execCommand/format-block-multiple-paragraphs-in-pre.html
(right):

https://codereview.chromium.org/2277673002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/editing/execCommand/format-block-multiple-paragraphs-in-pre.html:28:
'hello\n\nworld\n\n^webkit\n|',
The original test formats all but the last paragraph. The initial selection
should be '^hello\n\nworld\n\n|webkit\n'

https://codereview.chromium.org/2277673002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/editing/execCommand/format-block-multiple-paragraphs-in-pre.html:46:
'hello\n\n^world\n\nwebkit\n|',
Should be 'hello\n^\nworld\n\nwebkit\n|'

[yosin_UTC9, 2016-08-25 04:12:38]

Description was changed from

==========
Convert editing/execCommand/crash-indenting-list-item.html to use w3c test
harness

This patch converts "editing/execCommand/crash-indenting-list-item.html" to use
w3c test harness to simplify test script for improving readability.

BUG=n/a
TEST=n/a; no behavior changes
==========

to

==========
Convert editing/execCommand/format-block-multiple-paragraphs-in-pre.html to use
w3c test harness

This patch converts
"editing/execCommand/format-block-multiple-paragraphs-in-pre.html"
to use w3c test harness to simplify test script for improving readability.

BUG=n/a
TEST=n/a; no behavior changes
==========

[yosin_UTC9, 2016-08-25 04:23:14]

The CQ bit was checked by yosin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-25 04:23:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yosin_UTC9, 2016-08-25 05:15:43]

PTAL

Updated sample and expected texts.

https://codereview.chromium.org/2277673002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/editing/execCommand/format-block-multiple-paragraphs-in-pre.html
(right):

https://codereview.chromium.org/2277673002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/editing/execCommand/format-block-multiple-paragraphs-in-pre.html:28:
'hello\n\nworld\n\n^webkit\n|',
On 2016/08/25 at 01:48:39, Xiaocheng wrote:
> The original test formats all but the last paragraph. The initial selection
should be '^hello\n\nworld\n\n|webkit\n'

Done.

https://codereview.chromium.org/2277673002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/editing/execCommand/format-block-multiple-paragraphs-in-pre.html:46:
'hello\n\n^world\n\nwebkit\n|',
On 2016/08/25 at 01:48:39, Xiaocheng wrote:
> Should be 'hello\n^\nworld\n\nwebkit\n|'

Done.

[Xiaocheng, 2016-08-25 05:38:30]

lgtm with a nit

https://codereview.chromium.org/2277673002/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/editing/execCommand/format-block-multiple-paragraphs-in-pre.html
(right):

https://codereview.chromium.org/2277673002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/editing/execCommand/format-block-multiple-paragraphs-in-pre.html:40:
'formatBlock on last paragraph with H3');
nit: all but the last paragraph

[commit-bot: I haz the power, 2016-08-25 05:48:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-25 05:48:52]

Dry run: This issue passed the CQ dry run.

[yosin_UTC9, 2016-08-25 06:25:25]

The CQ bit was checked by yosin@chromium.org

[commit-bot: I haz the power, 2016-08-25 06:25:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-25 06:30:19]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-25 06:32:23]

Description was changed from

==========
Convert editing/execCommand/format-block-multiple-paragraphs-in-pre.html to use
w3c test harness

This patch converts
"editing/execCommand/format-block-multiple-paragraphs-in-pre.html"
to use w3c test harness to simplify test script for improving readability.

BUG=n/a
TEST=n/a; no behavior changes
==========

to

==========
Convert editing/execCommand/format-block-multiple-paragraphs-in-pre.html to use
w3c test harness

This patch converts
"editing/execCommand/format-block-multiple-paragraphs-in-pre.html"
to use w3c test harness to simplify test script for improving readability.

BUG=n/a
TEST=n/a; no behavior changes

Committed: https://crrev.com/2c1178c2b9f661399c61234b88375ec72320dadf
Cr-Commit-Position: refs/heads/master@{#414339}
==========

[commit-bot: I haz the power, 2016-08-25 06:32:24]

Patchset 2 (id:??) landed as
https://crrev.com/2c1178c2b9f661399c61234b88375ec72320dadf
Cr-Commit-Position: refs/heads/master@{#414339}